Plumb Task Scheduler Histograms to the Task Scheduler Internals Page

base/task_scheduler/task_scheduler_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/task_scheduler/task_scheduler_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/ptr_util.h"
+#include "base/metrics/histogram_base.h"
 #include "base/task_scheduler/scheduler_service_thread.h"
 #include "base/task_scheduler/scheduler_worker_pool_params.h"
 #include "base/task_scheduler/sequence_sort_key.h"
 #include "base/task_scheduler/task.h"
 #include "base/time/time.h"
 
 namespace base {
 namespace internal {
 
 // static
@@ skipping 23 matching lines @@
       make_scoped_refptr(new Sequence), nullptr);
 }
 
 scoped_refptr<TaskRunner> TaskSchedulerImpl::CreateTaskRunnerWithTraits(
     const TaskTraits& traits,
     ExecutionMode execution_mode) {
   return GetWorkerPoolForTraits(traits)->CreateTaskRunnerWithTraits(
       traits, execution_mode);
 }
 
+std::vector<const HistogramBase*> TaskSchedulerImpl::GetHistograms() {

[fdoray, 2016/10/14 20:59:05]

... GetHistograms() const {

[robliao, 2016/10/17 22:36:57]

Done.

+  std::vector<const HistogramBase*> histograms;
+  for (const auto& worker_pool : worker_pools_) {

[fdoray, 2016/10/14 20:59:06]

Could worker pools have a GetHistograms() method?

That way we wouldn't have to change task_scheduler_impl.cc when we add new
histograms in a worker pool. Also, it would be nice if this code supported
SchedulerWorkerPool impls with different sets of histograms (e.g. a
SchedulerWorkerPool backed by the Windows thread pool will not have detach
histograms).

[robliao, 2016/10/17 22:36:57]

Done.

+    histograms.push_back(worker_pool->detach_duration_histogram());
+    histograms.push_back(worker_pool->num_tasks_between_waits_histogram());
+  }
+  return histograms;
+}
+
 void TaskSchedulerImpl::Shutdown() {
   // TODO(fdoray): Increase the priority of BACKGROUND tasks blocking shutdown.
   task_tracker_.Shutdown();
 }
 
 void TaskSchedulerImpl::FlushForTesting() {
   task_tracker_.Flush();
 }
 
 void TaskSchedulerImpl::JoinForTesting() {
@@ skipping 63 matching lines @@
   GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence),
                                                     sort_key);
 }
 
 void TaskSchedulerImpl::OnDelayedRunTimeUpdated() {
   service_thread_->WakeUp();
 }
 
 }  // namespace internal
 }  // namespace base