Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4023)

Unified Diff: buildbot/buildbot_selector.py

Issue 2420943003: Disable GN build on Vista-64. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/buildbot_selector.py
diff --git a/buildbot/buildbot_selector.py b/buildbot/buildbot_selector.py
index e1921c1b8f331a2beddba695108fabd54ce1eba4..fb5d1d6f1575e0e5fe7da2160458cd953063775c 100755
--- a/buildbot/buildbot_selector.py
+++ b/buildbot/buildbot_selector.py
@@ -265,6 +265,9 @@ for platform in [
# Test with Breakpad tools only on basic Linux builds.
if sys.platform.startswith('linux'):
arch_flags += ' --use-breakpad-tools'
+ # GN executable can no longer run on Vista.
+ if platform == 'vista':
+ arch_flags += ' --no-gn'
for mode in ['dbg', 'opt']:
for libc in ['newlib', 'glibc']:
# Buildbots.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698