Remove the syzygy optimization code.

Remove the syzygy optimization code.

BUG=651078
Committed: https://crrev.com/dc24dfdf83e70db531ca2dcb1d9a304415951400
Cr-Commit-Position: refs/heads/master@{#425775}

[Sébastien Marchand, 2016-10-14 16:04:52]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 16:05:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 17:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 17:36:32]

Dry run: This issue passed the CQ dry run.

[Sébastien Marchand, 2016-10-14 20:01:28]

sebmarchand@chromium.org changed reviewers:
+ chrisha@chromium.org

[Sébastien Marchand, 2016-10-14 20:01:29]

PTAL.

[chrisha, 2016-10-14 20:07:31]

+cc siggi@

End of an era!

lgtm!

[grt (UTC plus 2), 2016-10-14 20:10:02]

grt@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2016-10-14 20:10:02]

I am pouring one out as we speak!

[Sigurður Ásgeirsson, 2016-10-14 20:14:44]

siggi@chromium.org changed reviewers:
+ siggi@chromium.org

[Sigurður Ásgeirsson, 2016-10-14 20:14:45]

lgtm - with a hint of melancholy.

[Sébastien Marchand, 2016-10-14 20:15:54]

sebmarchand@chromium.org changed reviewers:
+ brucedawson@chromium.org
- siggi@chromium.org

[Sébastien Marchand, 2016-10-14 20:15:55]

+grt@ for:
  chrome\installer\mini_installer\BUILD.gn
  chrome\tools\build\win\FILES.cfg

+brucedawson@ for:
  BUILD.gn
  build\config\compiler\compiler.gni

[grt (UTC plus 2), 2016-10-14 20:23:47]

aw, crap! you expect me to review this? well, a rubberstamp lgtm from me on the
mini_installer change. i think my privs for FILES.cfg were revoked when i broke
official builds a month or two ago, costing bruce a week's worth of work. bruce:
please review FILES.cfg as well. thanks.

godspeed you! black emperor.

[Sébastien Marchand, 2016-10-17 16:53:40]

sebmarchand@chromium.org changed reviewers:
+ mmoss@chromium.org

[Sébastien Marchand, 2016-10-17 16:53:41]

+mmoss@ for the changes to FILES.cfg

We still need syzygy/mini_installer.exe for the Win-Asan builds.

[Michael Moss, 2016-10-17 17:06:27]

lgtm

[brucedawson, 2016-10-17 18:02:43]

On 2016/10/14 20:23:47, grt (no reviews Oct 17-21) wrote:
> i think my privs for FILES.cfg were revoked when i broke
> official builds a month or two ago, costing bruce a week's worth of work.
bruce:
> please review FILES.cfg as well. thanks.

You exaggerate greatly. Plus, I don't pretend to understand files.cfg either.
But hey, lgtm, and let's all watch for unexpected failures.

[Sébastien Marchand, 2016-10-17 18:11:42]

Thanks everyone, the worst thing that can happen is that it'll break the
official Win builder, but we don't ship these builds anyway. I'll keep an eye on
it.

[Sébastien Marchand, 2016-10-17 18:26:22]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-10-17 18:26:22]

The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org,
siggi@chromium.org, chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2420943002/#ps20001
(title: "Remove the syzygy optimization code.")

[commit-bot: I haz the power, 2016-10-17 18:26:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 21:04:15]

Description was changed from

==========
Remove the syzygy optimization code.

BUG=651078
==========

to

==========
Remove the syzygy optimization code.

BUG=651078

Committed: https://crrev.com/dc24dfdf83e70db531ca2dcb1d9a304415951400
Cr-Commit-Position: refs/heads/master@{#425775}
==========

[commit-bot: I haz the power, 2016-10-17 21:04:17]

Patchset 2 (id:??) landed as
https://crrev.com/dc24dfdf83e70db531ca2dcb1d9a304415951400
Cr-Commit-Position: refs/heads/master@{#425775}

[commit-bot: I haz the power, 2016-10-17 21:05:05]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean