Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2420933002: predictors: Add trace events to the resource_prefetch_predictor. (Closed)

Created:
4 years, 2 months ago by Benoit L
Modified:
4 years, 2 months ago
Reviewers:
pasko
CC:
chromium-reviews, shishir+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Add trace events to the resource_prefetch_predictor. BUG=631966 Committed: https://crrev.com/c4dda66f74eba523c3860b4256163f3496c60220 Cr-Commit-Position: refs/heads/master@{#425592}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.cc View 4 chunks +7 lines, -0 lines 1 comment Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benoit L
4 years, 2 months ago (2016-10-14 15:46:26 UTC) #2
pasko
lgtm, good idea https://codereview.chromium.org/2420933002/diff/20001/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2420933002/diff/20001/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode590 chrome/browser/predictors/resource_prefetch_predictor.cc:590: TRACE_EVENT1("browser", "ResourcePrefetchPredictor::StartPrefetching", "url", traces in category ...
4 years, 2 months ago (2016-10-14 15:59:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420933002/20001
4 years, 2 months ago (2016-10-16 15:53:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-16 16:28:47 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-16 16:31:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4dda66f74eba523c3860b4256163f3496c60220
Cr-Commit-Position: refs/heads/master@{#425592}

Powered by Google App Engine
This is Rietveld 408576698