Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 242093003: QUIC: When sending a RST stream for flow control accounting purposes, (Closed)

Created:
6 years, 8 months ago by ramant (doing other things)
Modified:
6 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

QUIC: When sending a RST stream for flow control accounting purposes, include a more descriptive error code. Prompted by alyssar's comment in internal change: 61236803 Chromium specific code: + deleted unused ConstructRstPacket method from QuicNetworkTransactionTest. + Changed ConstructRstPacket to use the new descriptive error code. Merge internal change: 64774941 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M net/quic/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 8 months ago (2014-04-18 01:35:30 UTC) #1
Ryan Hamilton
6 years, 8 months ago (2014-04-18 03:34:39 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698