Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2420903002: Bug Fix: Initialize |disable_local_echo| (Closed)

Created:
4 years, 2 months ago by qiangchen
Modified:
4 years, 2 months ago
Reviewers:
xhwang
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bug Fix: Initialize |disable_local_echo| This CL fixes the cause to a memory test failure. We did not initialize a field of StreamControls. BUG=655973 Committed: https://crrev.com/7098f1cafa2dc58dd43856c413987a5c25fa54fc Cr-Commit-Position: refs/heads/master@{#425362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/common/media/media_stream_options.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qiangchen
Can you take a look at this simple fix?
4 years, 2 months ago (2016-10-14 15:12:59 UTC) #5
xhwang
I am not familiar with this code, but it does lgtm :)
4 years, 2 months ago (2016-10-14 16:32:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420903002/1
4 years, 2 months ago (2016-10-14 16:51:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 16:55:49 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:59:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7098f1cafa2dc58dd43856c413987a5c25fa54fc
Cr-Commit-Position: refs/heads/master@{#425362}

Powered by Google App Engine
This is Rietveld 408576698