Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2420883003: Change "insecure" to "not secure"/"non-secure" in DevTools. (Closed)

Created:
4 years, 2 months ago by lgarron
Modified:
4 years, 2 months ago
Reviewers:
dgozman, estark
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, emilyschechter, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change "insecure" to "not secure"/"non-secure" in DevTools. BUG=655886 Committed: https://crrev.com/0e9e7f5f7700981206ca29133190091d62d58f26 Cr-Commit-Position: refs/heads/master@{#425861}

Patch Set 1 #

Patch Set 2 : ...layout_tests #

Messages

Total messages: 17 (7 generated)
lgarron
estark@, dgozman@, could you review?
4 years, 2 months ago (2016-10-14 21:02:51 UTC) #2
dgozman
The bug number is wrong.
4 years, 2 months ago (2016-10-14 21:41:48 UTC) #3
lgarron
Indeed; thanks for catching. Updated.
4 years, 2 months ago (2016-10-14 21:44:37 UTC) #5
dgozman
lgtm
4 years, 2 months ago (2016-10-14 21:51:17 UTC) #6
estark
lgtm but I think you'll have to update the layout tests too.
4 years, 2 months ago (2016-10-14 23:54:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420883003/20001
4 years, 2 months ago (2016-10-15 07:37:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/296267)
4 years, 2 months ago (2016-10-15 08:07:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420883003/20001
4 years, 2 months ago (2016-10-18 00:51:07 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 02:25:24 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 02:27:48 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e9e7f5f7700981206ca29133190091d62d58f26
Cr-Commit-Position: refs/heads/master@{#425861}

Powered by Google App Engine
This is Rietveld 408576698