Chromium Code Reviews
DescriptionRevert of Fix FlatTreeTraversal for a slot in a document tree (patchset #3 id:40001 of https://codereview.chromium.org/2416833002/ )
Reason for revert:
The following content_browsertests have started consistently failing on KitKat Tablet Tester, Lollipop Tablet Tester and Marshmallow Tablet Tester:
FindRequestManagerTests/FindRequestManagerTest.RemoveFrame/0
FindRequestManagerTest.AddFrameAfterNoMatches
FindRequestManagerTests/FindRequestManagerTest.AddFrame/0
FindRequestManagerTest.HiddenFrame
FindRequestManagerTests/FindRequestManagerTest.CharacterByCharacter/0
FindRequestManagerTests/FindRequestManagerTest.Basic/0
FindRequestManagerTest.FindInPage_Issue627799
FindRequestManagerTest.ActivateNearestFindMatch
FindRequestManagerTest.FindMatchRects
FindRequestManagerTests/FindRequestManagerTest.NavigateFrame/0
FindRequestManagerTest.FindInPage_Issue644448
FindRequestManagerTests/FindRequestManagerTest.FindNewMatches/0
FindRequestManagerTests/FindRequestManagerTest.RapidFire/0
e.g. https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/5889
And the stack_tool_with_logcat_dump/stack_tool_for_tombstones steps both prominently feature findPlainTextInternal<blink::EditingAlgorithm<blink::FlatTreeTraversal>>
(oddly on KitKat Tablet Tester these tests started failing on the build after this patch landed; presumably the failure is at least partly flaky)
Original issue's description:
> Fix FlatTreeTraversal for a slot in a document tree
>
> Fix FlatTreeTraversal so that it considers a slot in a document tree correctly.
>
> Slots in a document tree are not well supported. They need a special treatment.
> This CL fixes the crash reported in the bug.
>
> BUG=649576
>
> Committed: https://crrev.com/dce2e40e8f3b783ef18e06b72c955bf59ed122d9
> Cr-Commit-Position: refs/heads/master@{#425252}
TBR=tkent@chromium.org,yosin@chromium.org,hayato@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=649576
Committed: https://crrev.com/3733b9b59c42ea60a6faf1bcfcf0ef30124e90cc
Cr-Commit-Position: refs/heads/master@{#425293}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||