Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2420883002: Revert of Fix FlatTreeTraversal for a slot in a document tree (Closed)

Created:
4 years, 2 months ago by johnme
Modified:
4 years, 2 months ago
Reviewers:
tkent, hayato, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix FlatTreeTraversal for a slot in a document tree (patchset #3 id:40001 of https://codereview.chromium.org/2416833002/ ) Reason for revert: The following content_browsertests have started consistently failing on KitKat Tablet Tester, Lollipop Tablet Tester and Marshmallow Tablet Tester: FindRequestManagerTests/FindRequestManagerTest.RemoveFrame/0 FindRequestManagerTest.AddFrameAfterNoMatches FindRequestManagerTests/FindRequestManagerTest.AddFrame/0 FindRequestManagerTest.HiddenFrame FindRequestManagerTests/FindRequestManagerTest.CharacterByCharacter/0 FindRequestManagerTests/FindRequestManagerTest.Basic/0 FindRequestManagerTest.FindInPage_Issue627799 FindRequestManagerTest.ActivateNearestFindMatch FindRequestManagerTest.FindMatchRects FindRequestManagerTests/FindRequestManagerTest.NavigateFrame/0 FindRequestManagerTest.FindInPage_Issue644448 FindRequestManagerTests/FindRequestManagerTest.FindNewMatches/0 FindRequestManagerTests/FindRequestManagerTest.RapidFire/0 e.g. https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/5889 And the stack_tool_with_logcat_dump/stack_tool_for_tombstones steps both prominently feature findPlainTextInternal<blink::EditingAlgorithm<blink::FlatTreeTraversal>> (oddly on KitKat Tablet Tester these tests started failing on the build after this patch landed; presumably the failure is at least partly flaky) Original issue's description: > Fix FlatTreeTraversal for a slot in a document tree > > Fix FlatTreeTraversal so that it considers a slot in a document tree correctly. > > Slots in a document tree are not well supported. They need a special treatment. > This CL fixes the crash reported in the bug. > > BUG=649576 > > Committed: https://crrev.com/dce2e40e8f3b783ef18e06b72c955bf59ed122d9 > Cr-Commit-Position: refs/heads/master@{#425252} TBR=tkent@chromium.org,yosin@chromium.org,hayato@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649576 Committed: https://crrev.com/3733b9b59c42ea60a6faf1bcfcf0ef30124e90cc Cr-Commit-Position: refs/heads/master@{#425293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -36 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
johnme
Created Revert of Fix FlatTreeTraversal for a slot in a document tree
4 years, 2 months ago (2016-10-14 11:21:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420883002/1
4 years, 2 months ago (2016-10-14 11:21:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 11:23:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3733b9b59c42ea60a6faf1bcfcf0ef30124e90cc Cr-Commit-Position: refs/heads/master@{#425293}
4 years, 2 months ago (2016-10-14 11:26:22 UTC) #7
hayato
4 years, 2 months ago (2016-10-17 04:22:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2427443003/ by hayato@chromium.org.

The reason for reverting is: It looks that the original CL is not culprit
because the tests still fail after reverting the CL
 
https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%2...

Let me reland this CL..

Powered by Google App Engine
This is Rietveld 408576698