Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2420863002: Remove usage of FOR_EACH_OBSERVER macro in ash/aura (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in ash/aura Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/92ce34a01bdadbeeec6ed4469574351eae9a7764 Cr-Commit-Position: refs/heads/master@{#425459}

Patch Set 1 #

Total comments: 2

Patch Set 2 : braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M ash/aura/pointer_watcher_adapter.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 1 1 chunk +10 lines, -10 lines 0 comments Download
M ash/aura/wm_window_aura.cc View 3 chunks +24 lines, -21 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Eric Willigers
4 years, 2 months ago (2016-10-14 06:50:20 UTC) #6
Daniel Erat
lgtm with a nit https://codereview.chromium.org/2420863002/diff/1/ash/aura/wm_shell_aura.cc File ash/aura/wm_shell_aura.cc (right): https://codereview.chromium.org/2420863002/diff/1/ash/aura/wm_shell_aura.cc#newcode317 ash/aura/wm_shell_aura.cc:317: for (auto& observer : activation_observers_) ...
4 years, 2 months ago (2016-10-14 15:18:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420863002/1
4 years, 2 months ago (2016-10-14 19:55:37 UTC) #9
Eric Willigers
https://codereview.chromium.org/2420863002/diff/1/ash/aura/wm_shell_aura.cc File ash/aura/wm_shell_aura.cc (right): https://codereview.chromium.org/2420863002/diff/1/ash/aura/wm_shell_aura.cc#newcode317 ash/aura/wm_shell_aura.cc:317: for (auto& observer : activation_observers_) On 2016/10/14 15:18:20, Daniel ...
4 years, 2 months ago (2016-10-14 20:16:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420863002/20001
4 years, 2 months ago (2016-10-14 20:17:22 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 20:49:32 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 20:51:34 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92ce34a01bdadbeeec6ed4469574351eae9a7764
Cr-Commit-Position: refs/heads/master@{#425459}

Powered by Google App Engine
This is Rietveld 408576698