Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 2420843004: Clean up mojom::Renderer usage in RPH (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up mojom::Renderer usage in RPH This gets rid of the ugly UserData + static accessor pattern which was used to expose a private mojom interface on RPH. Instead the mojom interface is forward-declared and a public accessor is added to RPH despite being unusable by content embedders. BUG=612500 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/ee0368989c05233d6329ddc5206ed1d7e3c44c98 Cr-Commit-Position: refs/heads/master@{#425598}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -52 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 5 chunks +6 lines, -40 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Ken Rockot(use gerrit already)
4 years, 2 months ago (2016-10-14 21:01:29 UTC) #5
jam
lgtm
4 years, 2 months ago (2016-10-15 00:06:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420843004/1
4 years, 2 months ago (2016-10-16 21:37:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/287102)
4 years, 2 months ago (2016-10-16 21:39:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420843004/20001
4 years, 2 months ago (2016-10-16 22:35:35 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-16 22:44:57 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-16 22:47:33 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee0368989c05233d6329ddc5206ed1d7e3c44c98
Cr-Commit-Position: refs/heads/master@{#425598}

Powered by Google App Engine
This is Rietveld 408576698