Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2420843002: Do not watch for low disk events in guest mode. (Closed)

Created:
4 years, 2 months ago by dspaid
Modified:
4 years, 2 months ago
Reviewers:
oshima, fukino
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not watch for low disk events in guest mode. Guest sessions do not store data on the persistent disk and therefore should not receive notifications regarding low disk space. BUG=655879 TEST=Log in to device as non-guest Create a sufficiently large file in Downloads to trigger low disk notifications Log out Log in as guest user Observe that no low disk notification is shown. Committed: https://crrev.com/44a5f92dde8b3cb2fa8d54b02fa97d08f0ee494a Cr-Commit-Position: refs/heads/master@{#425823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dspaid
+Oshima for owners approval +Fukino for context on related issue
4 years, 2 months ago (2016-10-14 04:30:57 UTC) #2
oshima
lgtm
4 years, 2 months ago (2016-10-17 17:13:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420843002/1
4 years, 2 months ago (2016-10-17 23:54:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 00:00:04 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 00:01:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44a5f92dde8b3cb2fa8d54b02fa97d08f0ee494a
Cr-Commit-Position: refs/heads/master@{#425823}

Powered by Google App Engine
This is Rietveld 408576698