Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Side by Side Diff: media/base/android/media_codec_util.cc

Issue 2420833003: Blacklist Samsung Galaxy Star and Samsung Galaxy Win (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/android/media_codec_util.h" 5 #include "media/base/android/media_codec_util.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 return Java_MediaCodecUtil_isDecoderSupportedForDevice(env, j_mime); 87 return Java_MediaCodecUtil_isDecoderSupportedForDevice(env, j_mime);
88 } 88 }
89 89
90 // static 90 // static
91 bool MediaCodecUtil::IsMediaCodecAvailable() { 91 bool MediaCodecUtil::IsMediaCodecAvailable() {
92 // Blacklist some devices on Jellybean as MediaCodec is buggy. 92 // Blacklist some devices on Jellybean as MediaCodec is buggy.
93 // http://crbug.com/365494, http://crbug.com/615872 93 // http://crbug.com/365494, http://crbug.com/615872
94 // Blacklist Lenovo A6600 / A6800 on KitKat, which tends to crash a lot. 94 // Blacklist Lenovo A6600 / A6800 on KitKat, which tends to crash a lot.
95 // See crbug.com/628059 . We include < K since they don't exist. 95 // See crbug.com/628059 . We include < K since they don't exist.
96 // Blacklist Samsung Galaxy Star Pro (GT-S7262) (crbug.com/634920). 96 // Blacklist Samsung Galaxy Star Pro (GT-S7262) (crbug.com/634920).
97 // GT-S5282 and GT-I8552 are for crbug.com/634920 .
97 if (base::android::BuildInfo::GetInstance()->sdk_int() <= 19) { 98 if (base::android::BuildInfo::GetInstance()->sdk_int() <= 19) {
98 std::string model(base::android::BuildInfo::GetInstance()->model()); 99 std::string model(base::android::BuildInfo::GetInstance()->model());
99 return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7000" && 100 return model != "GT-I9100" && model != "GT-I9300" && model != "GT-N7000" &&
100 model != "GT-N7100" && model != "A6600" && model != "A6800" && 101 model != "GT-N7100" && model != "A6600" && model != "A6800" &&
101 model != "GT-S7262"; 102 model != "GT-S7262" &&
103 model != "GT-S5282" && model != "GT-I8552";
102 } 104 }
103 105
104 return true; 106 return true;
105 } 107 }
106 108
107 // static 109 // static
108 bool MediaCodecUtil::SupportsSetParameters() { 110 bool MediaCodecUtil::SupportsSetParameters() {
109 // MediaCodec.setParameters() is only available starting with K. 111 // MediaCodec.setParameters() is only available starting with K.
110 return base::android::BuildInfo::GetInstance()->sdk_int() >= 19; 112 return base::android::BuildInfo::GetInstance()->sdk_int() >= 19;
111 } 113 }
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 (sdk_int == 18 && ("OMX.SEC.avc.dec" == codec_name || 247 (sdk_int == 18 && ("OMX.SEC.avc.dec" == codec_name ||
246 "OMX.SEC.avc.dec.secure" == codec_name)) || 248 "OMX.SEC.avc.dec.secure" == codec_name)) ||
247 (sdk_int == 19 && 249 (sdk_int == 19 &&
248 base::StartsWith(base::android::BuildInfo::GetInstance()->model(), 250 base::StartsWith(base::android::BuildInfo::GetInstance()->model(),
249 "SM-G800", base::CompareCase::INSENSITIVE_ASCII) && 251 "SM-G800", base::CompareCase::INSENSITIVE_ASCII) &&
250 ("OMX.Exynos.avc.dec" == codec_name || 252 ("OMX.Exynos.avc.dec" == codec_name ||
251 "OMX.Exynos.avc.dec.secure" == codec_name)); 253 "OMX.Exynos.avc.dec.secure" == codec_name));
252 } 254 }
253 255
254 } // namespace media 256 } // namespace media
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698