Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/test/data/webui/settings/settings_menu_test.js

Issue 2420833002: MD Settings: rework how advanced UI shows (Closed)
Patch Set: more tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_ui/settings_ui.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_menu_test.js b/chrome/test/data/webui/settings/settings_menu_test.js
index 0e6da83e5caccf6125dc935911dd147d52217241..2d0adbef5da96b49e00d28d6e495859aff3602a9 100644
--- a/chrome/test/data/webui/settings/settings_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_menu_test.js
@@ -18,10 +18,30 @@ cr.define('settings_menu', function() {
teardown(function() { settingsMenu.remove(); });
- test('openAdvanced', function() {
- settingsMenu.fire('toggle-advanced-page', true);
+ test('advancedOpenedBinding', function() {
+ assertFalse(settingsMenu.advancedOpened);
+ settingsMenu.advancedOpened = true;
Polymer.dom.flush();
assertTrue(settingsMenu.$.advancedPage.opened);
+
+ settingsMenu.advancedOpened = false;
+ Polymer.dom.flush();
+ assertFalse(settingsMenu.$.advancedPage.opened);
+ });
+
+ test('tapAdvanced', function() {
+ assertFalse(settingsMenu.advancedOpened);
+
+ var advancedTrigger = settingsMenu.$$('#advancedPage .menu-trigger');
+ assertTrue(!!advancedTrigger);
+
+ MockInteractions.tap(advancedTrigger);
+ Polymer.dom.flush();
+ assertTrue(settingsMenu.$.advancedPage.opened);
+
+ MockInteractions.tap(advancedTrigger);
+ Polymer.dom.flush();
+ assertFalse(settingsMenu.$.advancedPage.opened);
});
test('upAndDownIcons', function() {
@@ -31,12 +51,12 @@ cr.define('settings_menu', function() {
'.menu-trigger iron-icon');
assertTrue(!!ironIconElement);
- settingsMenu.fire('toggle-advanced-page', true);
+ settingsMenu.advancedOpened = true;
Polymer.dom.flush();
var openIcon = ironIconElement.icon;
assertTrue(!!openIcon);
- settingsMenu.fire('toggle-advanced-page', false);
+ settingsMenu.advancedOpened = false;
Polymer.dom.flush();
assertNotEquals(openIcon, ironIconElement.icon);
});
« no previous file with comments | « chrome/browser/resources/settings/settings_ui/settings_ui.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698