Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6461)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2420833002: MD Settings: rework how advanced UI shows (Closed)
Patch Set: more tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index a5ea67415c72771a59d19f10e99d435c55b4fcf3..0dc844153140173ff42c72f05199378935609b23 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -12,6 +12,11 @@ Polymer({
behaviors: [settings.RouteObserverBehavior],
properties: {
+ advancedOpened: {
+ type: Boolean,
+ notify: true,
+ },
+
/** @private */
aboutSelected_: Boolean,
@@ -24,26 +29,6 @@ Polymer({
},
},
- attached: function() {
- document.addEventListener('toggle-advanced-page', function(e) {
- if (e.detail)
- this.$.advancedPage.open();
- else
- this.$.advancedPage.close();
- }.bind(this));
-
- this.$.advancedPage.addEventListener('paper-submenu-open', function() {
- this.fire('toggle-advanced-page', true);
- }.bind(this));
-
- this.$.advancedPage.addEventListener('paper-submenu-close', function() {
- this.fire('toggle-advanced-page', false);
- }.bind(this));
-
- this.fire('toggle-advanced-page',
- settings.Route.ADVANCED.contains(settings.getCurrentRoute()));
- },
-
/**
* @param {!settings.Route} newRoute
*/

Powered by Google App Engine
This is Rietveld 408576698