Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2991)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2420833002: MD Settings: rework how advanced UI shows (Closed)
Patch Set: more tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index f931e6f0d5ada17b21a893cb1242ba9c06c49eea..d090cdedbb16ce619799256543678264361d0e9d 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -25,10 +25,10 @@ Polymer({
notify: true,
},
- /** @private */
- advancedToggleExpanded_: {
+ advancedToggleExpanded: {
type: Boolean,
- value: false,
+ notify: true,
+ observer: 'updatePagesShown_',
},
/**
@@ -90,11 +90,6 @@ Polymer({
/** @override */
attached: function() {
- document.addEventListener('toggle-advanced-page', function(e) {
- this.advancedToggleExpanded_ = e.detail;
- this.updatePagesShown_();
- }.bind(this));
-
var currentRoute = settings.getCurrentRoute();
this.hasExpandedSection_ = currentRoute && currentRoute.isSubpage();
},
@@ -206,7 +201,7 @@ Polymer({
this.hasExpandedSection_ = false;
if (settings.Route.ADVANCED.contains(newRoute))
- this.advancedToggleExpanded_ = true;
+ this.advancedToggleExpanded = true;
this.updatePagesShown_();
},
@@ -235,7 +230,7 @@ Polymer({
!this.hasExpandedSection_,
advanced: this.hasExpandedSection_ ?
settings.Route.ADVANCED.contains(currentRoute) :
- this.advancedToggleExpanded_,
+ this.advancedToggleExpanded,
};
}
@@ -292,7 +287,7 @@ Polymer({
/** @private */
toggleAdvancedPage_: function() {
- this.fire('toggle-advanced-page', !this.advancedToggleExpanded_);
+ this.advancedToggleExpanded = !this.advancedToggleExpanded;
},
/**

Powered by Google App Engine
This is Rietveld 408576698