MD Settings: rework how advanced UI shows

chrome/test/data/webui/settings/settings_menu_test.js

Index: chrome/test/data/webui/settings/settings_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_menu_test.js b/chrome/test/data/webui/settings/settings_menu_test.js
index 0e6da83e5caccf6125dc935911dd147d52217241..98b98f22dfdf83d864b115ed9e6fd00f59ded259 100644
--- a/chrome/test/data/webui/settings/settings_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_menu_test.js
@@ -19,7 +19,8 @@ cr.define('settings_menu', function() {
       teardown(function() { settingsMenu.remove(); });
 
       test('openAdvanced', function() {

[dpapad, 2016/10/17 19:11:43]

This tests that the binding causes the menu to update correctly, but can we also
add a test where a 'tap' is simulated on the "Advanced" entry in the menu?

[Dan Beam, 2016/10/17 20:52:17]

Done.

-        settingsMenu.fire('toggle-advanced-page', true);
+        assertFalse(settingsMenu.advancedOpened);
+        settingsMenu.advancedOpened = true;
         Polymer.dom.flush();
         assertTrue(settingsMenu.$.advancedPage.opened);

[dpapad, 2016/10/17 19:11:43]

Also, can we test the reverse too (closing after being open)?

settingsMenu.advancedOpened = false;
Polymer.dom.flush();
assertFalse(settingsMenu.$.advancedPage.opened);

[Dan Beam, 2016/10/17 20:52:17]

Done.

       });
@@ -31,12 +32,12 @@ cr.define('settings_menu', function() {
             '.menu-trigger iron-icon');
         assertTrue(!!ironIconElement);
 
-        settingsMenu.fire('toggle-advanced-page', true);
+        settingsMenu.advancedOpened = true;
         Polymer.dom.flush();
         var openIcon = ironIconElement.icon;
         assertTrue(!!openIcon);
 
-        settingsMenu.fire('toggle-advanced-page', false);
+        settingsMenu.advancedOpened = false;
         Polymer.dom.flush();
         assertNotEquals(openIcon, ironIconElement.icon);
       });