Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2420833002: MD Settings: rework how advanced UI shows (Closed)
Patch Set: more tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-ui' implements the UI for the Settings page. 7 * 'settings-ui' implements the UI for the Settings page.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 14 matching lines...) Expand all
25 */ 25 */
26 prefs: Object, 26 prefs: Object,
27 27
28 /** @type {?settings.DirectionDelegate} */ 28 /** @type {?settings.DirectionDelegate} */
29 directionDelegate: { 29 directionDelegate: {
30 observer: 'directionDelegateChanged_', 30 observer: 'directionDelegateChanged_',
31 type: Object, 31 type: Object,
32 value: new settings.DirectionDelegateImpl(), 32 value: new settings.DirectionDelegateImpl(),
33 }, 33 },
34 34
35 /** @private */
36 advancedOpened_: {
37 type: Boolean,
38 value: false,
39 notify: true,
40 },
41
35 /** @private {boolean} */ 42 /** @private {boolean} */
36 toolbarSpinnerActive_: { 43 toolbarSpinnerActive_: {
37 type: Boolean, 44 type: Boolean,
38 value: false, 45 value: false,
39 }, 46 },
40 47
41 /** 48 /**
42 * Dictionary defining page visibility. 49 * Dictionary defining page visibility.
43 * @private {!GuestModePageVisibility} 50 * @private {!GuestModePageVisibility}
44 */ 51 */
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 onMenuButtonTap_: function() { 128 onMenuButtonTap_: function() {
122 this.$$('app-drawer').toggle(); 129 this.$$('app-drawer').toggle();
123 }, 130 },
124 131
125 /** @private */ 132 /** @private */
126 directionDelegateChanged_: function() { 133 directionDelegateChanged_: function() {
127 this.$$('app-drawer').align = this.directionDelegate.isRtl() ? 134 this.$$('app-drawer').align = this.directionDelegate.isRtl() ?
128 'right' : 'left'; 135 'right' : 'left';
129 }, 136 },
130 }); 137 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/settings_ui/settings_ui.html ('k') | chrome/test/data/webui/settings/settings_menu_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698