MD Settings: rework how advanced UI shows

chrome/test/data/webui/settings/settings_menu_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs tests for the settings menu. */
 
 cr.define('settings_menu', function() {
   function registerSettingsMenuTest() {
     var settingsMenu = null;
 
     suite('SettingsMenu', function() {
       setup(function() {
         PolymerTest.clearBody();
         settingsMenu = document.createElement('settings-menu');
         settingsMenu.currentRoute = settings.Route.BASIC;
         document.body.appendChild(settingsMenu);
       });
 
       teardown(function() { settingsMenu.remove(); });
 
       test('openAdvanced', function() {

[dpapad, 2016/10/17 19:11:43]

This tests that the binding causes the menu to update correctly, but can we also
add a test where a 'tap' is simulated on the "Advanced" entry in the menu?

[Dan Beam, 2016/10/17 20:52:17]

Done.

-        settingsMenu.fire('toggle-advanced-page', true);
+        assertFalse(settingsMenu.advancedOpened);
+        settingsMenu.advancedOpened = true;
         Polymer.dom.flush();
         assertTrue(settingsMenu.$.advancedPage.opened);

[dpapad, 2016/10/17 19:11:43]

Also, can we test the reverse too (closing after being open)?

settingsMenu.advancedOpened = false;
Polymer.dom.flush();
assertFalse(settingsMenu.$.advancedPage.opened);

[Dan Beam, 2016/10/17 20:52:17]

Done.

       });
 
       test('upAndDownIcons', function() {
         // There should be different icons for a top level menu being open
         // vs. being closed. E.g. arrow-drop-up and arrow-drop-down.
         var ironIconElement = settingsMenu.$.advancedPage.querySelector(
             '.menu-trigger iron-icon');
         assertTrue(!!ironIconElement);
 
-        settingsMenu.fire('toggle-advanced-page', true);
+        settingsMenu.advancedOpened = true;
         Polymer.dom.flush();
         var openIcon = ironIconElement.icon;
         assertTrue(!!openIcon);
 
-        settingsMenu.fire('toggle-advanced-page', false);
+        settingsMenu.advancedOpened = false;
         Polymer.dom.flush();
         assertNotEquals(openIcon, ironIconElement.icon);
       });
 
       test('openResetSection', function() {
         settingsMenu.currentRoute = settings.Route.RESET;
         var advancedPage = settingsMenu.$.advancedPage;
         assertEquals('/reset',
             advancedPage.querySelector('paper-menu').selected);
       });
     });
   }
 
   return {
     registerTests: function() {
       registerSettingsMenuTest();
     },
   };
 });