ash/public/interfaces/locale.mojom - Issue 2420753002: ash: Use mojo LocaleNotificationController interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/public/interfaces/locale.mojom

Issue 2420753002: ash: Use mojo LocaleNotificationController interface. (Closed)

Patch Set: Fixes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module ash.mojom;

	6

	7 enum LocaleNotificationResult {
	msw 2016/10/17 22:19:34 nit: comment, mojoms should be thoroughly document nit: comment, mojoms should be thoroughly documented. (you'll need OWNERS review, and they'll say the same) Elliot Glaysher 2016/10/17 22:37:17 Done. Show quoted text On 2016/10/17 22:19:34, msw wrote: > nit: comment, mojoms should be thoroughly documented. > (you'll need OWNERS review, and they'll say the same) Done.
	8 ACCEPT,

	9 REVERT

	10 };

	11

	12 // Used by Chrome to make ash show a notification.

	13 interface LocaleNotificationController {

	14 OnLocaleChanged(string current, string from, string to)
	msw 2016/10/17 22:19:34 ditto nit: comment. ditto nit: comment. Elliot Glaysher 2016/10/17 22:37:17 Done. Show quoted text On 2016/10/17 22:19:34, msw wrote: > ditto nit: comment. Done.
	15 => (LocaleNotificationResult result);

	16 };

OLD	NEW