Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2047)

Unified Diff: device/vr/vr_service.mojom

Issue 2420743003: mojo VR interface simplified (Closed)
Patch Set: update binding process and update some unittest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/vr/vr_device_provider.h ('k') | device/vr/vr_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/vr/vr_service.mojom
diff --git a/device/vr/vr_service.mojom b/device/vr/vr_service.mojom
index 5dbf7025641ca0edd5f616e0ca2ba6d4a4f03df3..aecfa68a02e9304deac3edce2aed003dc1502ba9 100644
--- a/device/vr/vr_service.mojom
+++ b/device/vr/vr_service.mojom
@@ -1,6 +1,5 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
+// Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file.
module device;
@@ -49,7 +48,6 @@ struct VRStageParameters {
};
struct VRDisplay {
- uint32 index;
string displayName;
VRDisplayCapabilities capabilities;
VRStageParameters? stageParameters;
@@ -57,6 +55,11 @@ struct VRDisplay {
VREyeParameters rightEye;
};
+struct VRDisplayWithService {
+ VRDisplay? display;
+ VRDeviceClient? service;
+};
+
struct VRLayerBounds {
float left;
float top;
@@ -65,22 +68,32 @@ struct VRLayerBounds {
};
interface VRService {
+ GetDisplays() => (bool success);
SetClient(VRServiceClient client);
+};
- GetDisplays() => (array<VRDisplay> displays);
+interface VRServiceClient {
[Sync]
- GetPose(uint32 index) => (VRPose? pose);
- ResetPose(uint32 index);
+ GetDisplayClient() => (VRDisplayClient? client);
+};
- RequestPresent(uint32 index, bool secureOrigin) => (bool success);
- ExitPresent(uint32 index);
- SubmitFrame(uint32 index, VRPose? pose);
- UpdateLayerBounds(uint32 index, VRLayerBounds leftBounds, VRLayerBounds rightBounds);
+interface VRDeviceClient {
leonhsl(Using Gerrit) 2016/10/25 03:17:40 Still old comments about interface naming... : (VR
+ [Sync]
+ GetPose() => (VRPose? pose);
+ ResetPose();
+
+ RequestPresent(bool secureOrigin) => (bool success);
+ ExitPresent();
+ SubmitFrame(VRPose? pose);
+ UpdateLayerBounds(VRLayerBounds leftBounds, VRLayerBounds rightBounds);
};
-interface VRServiceClient {
+interface VRDisplayClient {
+ RegisterDeviceClient(VRDeviceClient? device_client);
+ UpdateDisplayInfo(VRDisplay display);
+
OnDisplayChanged(VRDisplay display);
- OnExitPresent(uint32 index);
+ OnExitPresent();
OnDisplayConnected(VRDisplay display);
- OnDisplayDisconnected(uint32 index);
+ OnDisplayDisconnected();
};
« no previous file with comments | « device/vr/vr_device_provider.h ('k') | device/vr/vr_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698