Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Unified Diff: device/vr/android/gvr/gvr_device_provider.cc

Issue 2420743003: mojo VR interface simplified (Closed)
Patch Set: update binding process and update some unittest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/android/gvr/gvr_device_provider.cc
diff --git a/device/vr/android/gvr/gvr_device_provider.cc b/device/vr/android/gvr/gvr_device_provider.cc
index 1025ca40726bfe2136cc3ee93f18d62cc8b0d8fc..0679cbb57332232e35b2cd2b72d1fe58a3810bc6 100644
--- a/device/vr/android/gvr/gvr_device_provider.cc
+++ b/device/vr/android/gvr/gvr_device_provider.cc
@@ -83,22 +83,19 @@ GvrDeviceProvider::~GvrDeviceProvider() {
ExitPresent();
}
-void GvrDeviceProvider::GetDevices(std::vector<VRDevice*>* devices) {
- Initialize();
+void GvrDeviceProvider::GetDevices(std::vector<VRServiceImpl*>* clients,
+ std::vector<VRDevice*>* devices) {
+ Initialize(clients);
if (vr_device_)
devices->push_back(vr_device_.get());
}
-void GvrDeviceProvider::SetClient(VRClientDispatcher* client) {
- if (!client_)
- client_.reset(client);
-}
-
-void GvrDeviceProvider::Initialize() {
+void GvrDeviceProvider::Initialize(std::vector<VRServiceImpl*>* clients) {
if (!vr_device_) {
vr_device_.reset(new GvrDevice(this, nullptr));
- client_->OnDeviceConnectionStatusChanged(vr_device_.get(), true);
+ vr_device_->SetClient(clients);
+ vr_device_->OnDisplayConnected();
}
}
@@ -124,9 +121,6 @@ void GvrDeviceProvider::ExitPresent() {
GvrDelegateProvider* delegate_provider = GvrDelegateProvider::GetInstance();
if (delegate_provider)
delegate_provider->ExitWebVRPresent();
-
- if (client_)
- client_->OnPresentEnded(vr_device_.get());
}
void GvrDeviceProvider::OnGvrDelegateReady(GvrDelegate* delegate) {

Powered by Google App Engine
This is Rietveld 408576698