Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: device/vr/vr_device.cc

Issue 2420743003: mojo VR interface simplified (Closed)
Patch Set: Address bajones@ comments and some clean up Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/vr_device.cc
diff --git a/device/vr/vr_device.cc b/device/vr/vr_device.cc
index 5e3d7fc253d6fa29c2755622baf9241df7ca49b5..d4403e6d2c9d6a75153456b1ea9c0d361ec4ba83 100644
--- a/device/vr/vr_device.cc
+++ b/device/vr/vr_device.cc
@@ -4,13 +4,14 @@
#include "device/vr/vr_device.h"
#include "device/vr/vr_device_provider.h"
+#include "device/vr/vr_service_impl.h"
namespace device {
unsigned int VRDevice::next_id_ = 1;
VRDevice::VRDevice(VRDeviceProvider* provider)
- : provider_(provider), id_(next_id_) {
+ : presenting_service_(nullptr), provider_(provider), id_(next_id_) {
// Prevent wraparound. Devices with this ID will be treated as invalid.
if (next_id_ != VR_DEVICE_LAST_ID)
next_id_++;
@@ -18,8 +19,27 @@ VRDevice::VRDevice(VRDeviceProvider* provider)
VRDevice::~VRDevice() {}
-bool VRDevice::RequestPresent(bool secure_origin) {
+bool VRDevice::RequestPresent(VRServiceImpl* service, bool secure_origin) {
return true;
};
+void VRDevice::RegisterDisplayService(VRServiceImpl* service,
+ VRDisplayServicePtr display_service) {
+ display_services_.insert(std::pair<VRServiceImpl*, VRDisplayServicePtr>(
+ service, std::move(display_service)));
+}
+
+void VRDevice::RemoveService(VRServiceImpl* service) {
+ ExitPresent(service);
+ display_services_.erase(service);
+}
+
+bool VRDevice::CheckAccessAllowed(VRServiceImpl* service) {
+ return (!presenting_service_ || presenting_service_ == service);
+}
+
+bool VRDevice::IsPresentingService(VRServiceImpl* service) {
+ return (presenting_service_ && presenting_service_ == service);
+}
+
} // namespace device
« no previous file with comments | « device/vr/vr_device.h ('k') | device/vr/vr_device_manager.h » ('j') | device/vr/vr_service.mojom » ('J')

Powered by Google App Engine
This is Rietveld 408576698