Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1709)

Unified Diff: device/vr/android/gvr/gvr_device_provider.h

Issue 2420743003: mojo VR interface simplified (Closed)
Patch Set: address leon@ comments about name Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/android/gvr/gvr_device_provider.h
diff --git a/device/vr/android/gvr/gvr_device_provider.h b/device/vr/android/gvr/gvr_device_provider.h
index 23f8cb0832ebf83444db07b1a4d77cf6beffd24d..2fffb5610c0deb33090315a10929d7be6a42999f 100644
--- a/device/vr/android/gvr/gvr_device_provider.h
+++ b/device/vr/android/gvr/gvr_device_provider.h
@@ -9,7 +9,6 @@
#include "base/macros.h"
#include "base/single_thread_task_runner.h"
-#include "device/vr/vr_client_dispatcher.h"
#include "device/vr/vr_device.h"
#include "device/vr/vr_device_provider.h"
#include "device/vr/vr_export.h"
@@ -18,14 +17,16 @@ namespace device {
class GvrDelegate;
class GvrDevice;
+class VRServiceImpl;
class DEVICE_VR_EXPORT GvrDeviceProvider : public VRDeviceProvider {
public:
GvrDeviceProvider();
~GvrDeviceProvider() override;
- void GetDevices(std::vector<VRDevice*>* devices) override;
- void Initialize() override;
+ void GetDevices(std::vector<VRServiceImpl*>* clients,
+ std::vector<VRDevice*>* devices) override;
+ void Initialize(std::vector<VRServiceImpl*>* clients) override;
// Called from GvrDevice
bool RequestPresent();
@@ -35,13 +36,10 @@ class DEVICE_VR_EXPORT GvrDeviceProvider : public VRDeviceProvider {
void OnGvrDelegateReady(GvrDelegate* delegate);
void OnGvrDelegateRemoved();
- void SetClient(VRClientDispatcher* client) override;
-
private:
void GvrDelegateReady(GvrDelegate* delegate);
void GvrDelegateRemoved();
- std::unique_ptr<VRClientDispatcher> client_;
std::unique_ptr<GvrDevice> vr_device_;
scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698