mojo VR interface simplified

device/vr/vr_service.mojom

 // Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
+// Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file.
 
-module device;
+module device.mojom;
 
 // A field of view, given by 4 degrees describing the view from a center point.
 struct VRFieldOfView {
   float upDegrees;
   float downDegrees;
   float leftDegrees;
   float rightDegrees;
 };
 
 // A display's position, orientation, velocity, and acceleration state at the
@@ skipping 25 matching lines @@
   uint32 renderWidth;
   uint32 renderHeight;
 };
 
 struct VRStageParameters {
   array<float, 16> standingTransform;
   float sizeX;
   float sizeZ;
 };
 
-struct VRDisplay {
-   uint32 index;
-   string displayName;
-   VRDisplayCapabilities capabilities;
-   VRStageParameters? stageParameters;
-   VREyeParameters leftEye;
-   VREyeParameters rightEye;
+struct VRDisplayInfo {
+  // TODO : Remove this attribute with gamepad refactory.
+  uint32 index;
+  string displayName;
+  VRDisplayCapabilities capabilities;
+  VRStageParameters? stageParameters;
+  VREyeParameters leftEye;
+  VREyeParameters rightEye;
 };
 
 struct VRLayerBounds {
-   float left;
-   float top;
-   float width;
-   float height;
+  float left;
+  float top;
+  float width;
+  float height;
 };
 
 interface VRService {
-  SetClient(VRServiceClient client);
-
-  GetDisplays() => (array<VRDisplay> displays);
-  [Sync]
-  GetPose(uint32 index) => (VRPose? pose);
-  ResetPose(uint32 index);
-
-  RequestPresent(uint32 index, bool secureOrigin) => (bool success);
-  ExitPresent(uint32 index);
-  SubmitFrame(uint32 index, VRPose? pose);
-  UpdateLayerBounds(uint32 index, VRLayerBounds leftBounds, VRLayerBounds rightBounds);
+  SetClient(VRServiceClient client) => (uint32 num);

[dcheng, 2016/11/04 05:12:21]

In a followup, it'd be better if we had a factory function that took a
VRServiceClient so we would never have a half-initialized VRService: as it
stands, it's possible for the renderer to never set a client. The browser never
checks that client() is non-null.

Also, I'm not sure what |num| is: please make the name more descriptive.

[shaobo.yan, 2016/11/05 08:11:39]

num means connectedDeviceNumber I'll update it.
And I'll use a TODO to fix this.

 };
 
 interface VRServiceClient {
-  OnDisplayChanged(VRDisplay display);
-  OnExitPresent(uint32 index);
-  OnDisplayConnected(VRDisplay display);
-  OnDisplayDisconnected(uint32 index);
+  OnDisplayConnected(VRDisplay display, VRDisplayInfo displayInfo);
 };
+
+interface VRDisplay {
+  SetClient(VRDisplayClient client);

[dcheng, 2016/11/04 05:12:21]

Ditto: it'd be better for this to be created through some sort of factory
function, so that we're never in the half-initialized state. This one is easy to
fix: we can pass down a VRDisplayClient& in OnDisplayConnected().

[shaobo.yan, 2016/11/05 08:11:39]

Thx and I'll use TODO to follow this.

+
+  [Sync]
+  GetPose() => (VRPose? pose);
+  ResetPose();
+
+  RequestPresent(bool secureOrigin) => (bool success);
+  ExitPresent();
+  SubmitFrame(VRPose? pose);
+  UpdateLayerBounds(VRLayerBounds leftBounds, VRLayerBounds rightBounds);
+};
+
+interface VRDisplayClient {
+  OnDisplayChanged(VRDisplayInfo display);
+  OnExitPresent();
+};