Skip the OnDomContentLoaded event, and only use the OnLoad event.

Skip the OnDomContentLoaded event, and only use the OnLoad event.

In an attempt to improve the right moment detection, we will
no longer take snapshots of the (earlier) OnDomContentLoaded event,
and instead wait later for the OnLoad event.

BUG=649711
Committed: https://crrev.com/f13a8e04f192b954e9ce8a301e25dd8ef250dd84
Cr-Commit-Position: refs/heads/master@{#427537}

[Pete Williamson, 2016-10-13 19:35:59]

petewil@chromium.org changed reviewers:
+ dougarnett@chromium.org

[Pete Williamson, 2016-10-13 19:35:59]

Doug: What kind of testing do you think I should do before we check this in? 
For instance, I've loaded several pages, and they seem OK, but maybe I should do
the whole list of 55?

[dougarnett, 2016-10-13 20:00:14]

lgtm

I will send you links which were the partial and no real content urls with
GIN-2g-poor? I would like to see none fail and at least half of them get
majority of content (can still miss few images) with this change.


lgtm

[dougarnett, 2016-10-14 21:09:33]

-lgtm

My initial attempts (3) on some of the partial content urls haven't worked so
I'm not confident yet we can get away with just using OnLoad.

[dougarnett, 2016-10-14 21:27:52]

not lgtm

[dougarnett, 2016-10-25 22:26:55]

lgtm

From our evaluations, this change results in fewer pages captured but of better
quality. In particular, from my eval
on slow 2g network, we get good snapshots for about 50% the
URLs whereas before we got snapshots for about 75% of URLs
where 60% were good (but more missing images) and about 20%
had only half or so of the content. 

Let's consider this better fidelity change for M-55, then
try to do a bit better for M-56.

[Pete Williamson, 2016-10-25 23:11:18]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:11:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:44:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-25 23:46:19]

Description was changed from

==========
Skip the OnDomContentLoaded event, and only use the OnLoad event.

In an attempt to improve the right moment detection, we will
no longer take snapshots of the (earlier) OnDomContentLoaded event,
and instead wait later for the OnLoad event.

BUG=649711
==========

to

==========
Skip the OnDomContentLoaded event, and only use the OnLoad event.

In an attempt to improve the right moment detection, we will
no longer take snapshots of the (earlier) OnDomContentLoaded event,
and instead wait later for the OnLoad event.

BUG=649711

Committed: https://crrev.com/f13a8e04f192b954e9ce8a301e25dd8ef250dd84
Cr-Commit-Position: refs/heads/master@{#427537}
==========

[commit-bot: I haz the power, 2016-10-25 23:46:20]

Patchset 1 (id:??) landed as
https://crrev.com/f13a8e04f192b954e9ce8a301e25dd8ef250dd84
Cr-Commit-Position: refs/heads/master@{#427537}