Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2420673002: [css-grid] Recompute track sizes if fit-content() argument is modified (Closed)

Created:
4 years, 2 months ago by Manuel Rego
Modified:
4 years, 2 months ago
CC:
chromium-reviews, blink-reviews, svillar, jfernandez, Manuel Rego, blink-reviews-style_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Recompute track sizes if fit-content() argument is modified When fit-content() was implemented a new attribute m_fitContentTrackBreadth was added to GridTrackSize. However we forgot to include it in the == operator implementation, so we were missing the changes on that value. Now if you change the argument of a fit-content() track, the track size is properly recomputed. BUG=654712 TEST=fast/css-grid-layout/grid-change-fit-content-argument.html Committed: https://crrev.com/468f3c355c499087911dbb34c8d2ba6d9a014cff Cr-Commit-Position: refs/heads/master@{#425122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-change-fit-content-argument.html View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-change-fit-content-argument-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridTrackSize.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
4 years, 2 months ago (2016-10-13 16:51:12 UTC) #2
cbiesinger
heh, oops. lgtm.
4 years, 2 months ago (2016-10-13 17:11:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420673002/1
4 years, 2 months ago (2016-10-13 19:06:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 19:16:53 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 19:20:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/468f3c355c499087911dbb34c8d2ba6d9a014cff
Cr-Commit-Position: refs/heads/master@{#425122}

Powered by Google App Engine
This is Rietveld 408576698