Add a new annotation

Add a new annotation

R=pquitslund@google.com

Committed: https://github.com/dart-lang/sdk/commit/37890f995f68bf2074649faa5c4662716baf4381

[Alexei Diaz, 2016-10-13 16:36:57]

alexeidiaz@google.com changed reviewers:
+ alexeidiaz@google.com

[Alexei Diaz, 2016-10-13 16:36:58]

https://codereview.chromium.org/2420653002/diff/1/pkg/meta/lib/meta.dart
File pkg/meta/lib/meta.dart (right):

https://codereview.chromium.org/2420653002/diff/1/pkg/meta/lib/meta.dart#newc...
pkg/meta/lib/meta.dart:109: const _Virtual virtual = const _Virtual();
Could this somehow be extended to methods? Like the virtual access modifier in
C#.https://msdn.microsoft.com/en-us/library/9fkccyh4.aspx

[Brian Wilkerson, 2016-10-13 18:17:00]

https://codereview.chromium.org/2420653002/diff/1/pkg/meta/lib/meta.dart
File pkg/meta/lib/meta.dart (right):

https://codereview.chromium.org/2420653002/diff/1/pkg/meta/lib/meta.dart#newc...
pkg/meta/lib/meta.dart:109: const _Virtual virtual = const _Virtual();
This annotation (which wasn't added by this CL, merely moved when the file was
sorted) is used by DDC to allow more efficient code for fields that are not
annotated. There's currently no other benefit, and DDC currently doesn't provide
any benefit from using it for methods, so I'd hesitate to expand it's use.

[Brian Wilkerson, 2016-11-09 21:28:54]

brianwilkerson@google.com changed reviewers:
+ pquitslund@google.com
- alexeidiaz@google.com

[Brian Wilkerson, 2016-11-09 21:28:55]

I forgot to send this out for review earlier.

[pquitslund, 2016-11-09 22:08:09]

LGTM!

[Brian Wilkerson, 2016-11-09 22:19:30]

Description was changed from

==========
Add a new annotation
==========

to

==========
Add a new annotation

R=pquitslund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/37890f995f68bf2074649faa5c4662716baf4381
==========

[Brian Wilkerson, 2016-11-09 22:19:31]

Committed patchset #1 (id:1) manually as
37890f995f68bf2074649faa5c4662716baf4381 (presubmit successful).