Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: test/fuzzer/fuzzer.gyp

Issue 2420603002: Fix import/export annotations for v8 targets that are always static (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/fuzzer/fuzzer.gyp
diff --git a/test/fuzzer/fuzzer.gyp b/test/fuzzer/fuzzer.gyp
index 6a38e062a41e761e51d9d113a56470c5b808b33d..8f08b06c84e1ba95420731d99fb0babe5554aaa7 100644
--- a/test/fuzzer/fuzzer.gyp
+++ b/test/fuzzer/fuzzer.gyp
@@ -59,6 +59,13 @@
'sources': [ ### gcmole(all) ###
'parser.cc',
],
+ 'conditions': [
+ ['component=="shared_library"', {
+ # fuzzers can't be built against a shared library, so we need to
jgruber 2016/10/13 11:36:17 I don't understand this comment. Most fuzzers are
jochen (gone - plz use gerrit) 2016/10/13 12:16:34 right, that's a copy of the comment below. I'll re
+ # depend on the underlying static target in that case.
+ 'defines': [ 'BUILDING_V8_SHARED', ]
+ }],
+ ],
},
{
'target_name': 'v8_simple_regexp_fuzzer',
@@ -416,6 +423,7 @@
# fuzzers can't be built against a shared library, so we need to
Michael Achenbach 2016/10/13 11:39:30 I guess already this old comment is imprecise. It
# depend on the underlying static target in that case.
'dependencies': ['../../src/v8.gyp:v8_maybe_snapshot'],
+ 'defines': [ 'BUILDING_V8_SHARED', ]
}, {
'dependencies': ['../../src/v8.gyp:v8'],
}],
« BUILD.gn ('K') | « test/cctest/cctest.gyp ('k') | test/unittests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698