Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: test/fuzzer/fuzzer.gyp

Issue 2420603002: Fix import/export annotations for v8 targets that are always static (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'v8_code': 1, 7 'v8_code': 1,
8 }, 8 },
9 'includes': ['../../gypfiles/toolchain.gypi', '../../gypfiles/features.gypi'], 9 'includes': ['../../gypfiles/toolchain.gypi', '../../gypfiles/features.gypi'],
10 'targets': [ 10 'targets': [
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 'type': 'static_library', 52 'type': 'static_library',
53 'dependencies': [ 53 'dependencies': [
54 'fuzzer_support_nocomponent', 54 'fuzzer_support_nocomponent',
55 ], 55 ],
56 'include_dirs': [ 56 'include_dirs': [
57 '../..', 57 '../..',
58 ], 58 ],
59 'sources': [ ### gcmole(all) ### 59 'sources': [ ### gcmole(all) ###
60 'parser.cc', 60 'parser.cc',
61 ], 61 ],
62 'conditions': [
63 ['component=="shared_library"', {
64 # fuzzers can't be built against a shared library, so we need to
jgruber 2016/10/13 11:36:17 I don't understand this comment. Most fuzzers are
jochen (gone - plz use gerrit) 2016/10/13 12:16:34 right, that's a copy of the comment below. I'll re
65 # depend on the underlying static target in that case.
66 'defines': [ 'BUILDING_V8_SHARED', ]
67 }],
68 ],
62 }, 69 },
63 { 70 {
64 'target_name': 'v8_simple_regexp_fuzzer', 71 'target_name': 'v8_simple_regexp_fuzzer',
65 'type': 'executable', 72 'type': 'executable',
66 'dependencies': [ 73 'dependencies': [
67 'regexp_fuzzer_lib', 74 'regexp_fuzzer_lib',
68 ], 75 ],
69 'include_dirs': [ 76 'include_dirs': [
70 '../..', 77 '../..',
71 ], 78 ],
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 ], 413 ],
407 'include_dirs': [ 414 'include_dirs': [
408 '../..', 415 '../..',
409 ], 416 ],
410 'sources': [ ### gcmole(all) ### 417 'sources': [ ### gcmole(all) ###
411 'fuzzer-support.cc', 418 'fuzzer-support.cc',
412 'fuzzer-support.h', 419 'fuzzer-support.h',
413 ], 420 ],
414 'conditions': [ 421 'conditions': [
415 ['component=="shared_library"', { 422 ['component=="shared_library"', {
416 # fuzzers can't be built against a shared library, so we need to 423 # fuzzers can't be built against a shared library, so we need to
Michael Achenbach 2016/10/13 11:39:30 I guess already this old comment is imprecise. It
417 # depend on the underlying static target in that case. 424 # depend on the underlying static target in that case.
418 'dependencies': ['../../src/v8.gyp:v8_maybe_snapshot'], 425 'dependencies': ['../../src/v8.gyp:v8_maybe_snapshot'],
426 'defines': [ 'BUILDING_V8_SHARED', ]
419 }, { 427 }, {
420 'dependencies': ['../../src/v8.gyp:v8'], 428 'dependencies': ['../../src/v8.gyp:v8'],
421 }], 429 }],
422 ], 430 ],
423 }, 431 },
424 ], 432 ],
425 'conditions': [ 433 'conditions': [
426 ['test_isolation_mode != "noop"', { 434 ['test_isolation_mode != "noop"', {
427 'targets': [ 435 'targets': [
428 { 436 {
(...skipping 10 matching lines...) Expand all
439 '../../gypfiles/isolate.gypi', 447 '../../gypfiles/isolate.gypi',
440 ], 448 ],
441 'sources': [ 449 'sources': [
442 'fuzzer.isolate', 450 'fuzzer.isolate',
443 ], 451 ],
444 }, 452 },
445 ], 453 ],
446 }], 454 }],
447 ], 455 ],
448 } 456 }
OLDNEW
« BUILD.gn ('K') | « test/cctest/cctest.gyp ('k') | test/unittests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698