Fix import/export annotations for v8 targets that are always static

test/cctest/BUILD.gn

 # Copyright 2016 The V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("../../gni/v8.gni")
 
 v8_executable("cctest") {
   testonly = true
 
   sources = [
@@ skipping 299 matching lines @@
     sources += [ "test-platform-linux.cc" ]
   } else if (is_win) {
     sources += [ "test-platform-win32.cc" ]
   }
 
   configs = [
     "../..:external_config",
     "../..:internal_config_base",
   ]
 
-  if (is_win) {
-    remove_configs = [ "//build/config/win:default_incremental_linking" ]
-    configs += [ "//build/config/win:no_incremental_linking" ]
-  }
-
   # TODO(machenbach): Translate from gyp.
   #["OS=="aix"", {
   #  "ldflags": [ "-Wl,-bbigtoc" ],
   #}],
 
   deps = [
     ":resources",
     "../..:v8_libbase",
     "../..:v8_libplatform",
     "../..:wasm_module_runner",
     "../..:wasm_test_signatures",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
+  defines = []
+
   if (is_component_build) {
     # cctest can't be built against a shared library, so we
     # need to depend on the underlying static target in that case.
     deps += [ "../..:v8_maybe_snapshot" ]
+    defines += [ "BUILDING_V8_SHARED" ]
   } else {
     deps += [ "../..:v8" ]
   }
 
   cflags = []
   ldflags = []
 
   if (v8_current_cpu == "ppc" || v8_current_cpu == "ppc64" ||
       v8_current_cpu == "arm" || v8_current_cpu == "arm64" ||
       v8_current_cpu == "s390" || v8_current_cpu == "s390x") {
     # Disable fmadd/fmsub so that expected results match generated code in
     # RunFloat64MulAndFloat64Add1 and friends.
     cflags += [ "-ffp-contract=off" ]
   }
 
   if (is_win) {
     # This warning is benignly triggered by the U16 and U32 macros in
     # bytecode-utils.h.
     # C4309: 'static_cast': truncation of constant value
     cflags += [ "/wd4309" ]
 
     # MSVS wants this for gay-{precision,shortest}.cc.
     cflags += [ "/bigobj" ]
-
-    # Suppress warnings about importing locally defined symbols.
-    if (is_component_build) {
-      ldflags += [
-        "/ignore:4049",
-        "/ignore:4217",
-      ]
-    }
   }
 }
 
 action("resources") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   script = "../../tools/js2c.py"
 
   # The script depends on this other script, this rule causes a rebuild if it
   # changes.
@@ skipping 35 matching lines @@
     "../..:external_config",
     "../..:internal_config_base",
   ]
 
   deps = [
     "../..:v8_libplatform",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
+  defines = []
+
   if (is_component_build) {
     # Same as cctest, we need to depend on the underlying static target.
     deps += [ "../..:v8_maybe_snapshot" ]
+    defines += [ "BUILDING_V8_SHARED" ]
   } else {
     deps += [ "../..:v8" ]
   }
-
-  if (is_win) {
-    # Suppress warnings about importing locally defined symbols.
-    if (is_component_build) {
-      ldflags = [
-        "/ignore:4049",
-        "/ignore:4217",
-      ]
-    }
-  }
 }