Fix import/export annotations for v8 targets that are always static

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/dcheck_always_on.gni")
 import("//build/config/mips.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
@@ skipping 2384 matching lines @@
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   sources = [
     "test/fuzzer/fuzzer-support.cc",
     "test/fuzzer/fuzzer-support.h",
   ]
 
   configs = [ ":internal_config_base" ]
 
   deps = [
     ":v8_maybe_snapshot",

[jgruber, 2016/10/13 11:36:17]

Just checking - the distinction between fuzzer_support and
fuzzer_support_nocomponent is still needed because of the deps?

[jochen (gone - plz use gerrit), 2016/10/13 12:16:34]

that's mostly because of missing export annotations in the parser. I can fix
that in a follow-up cl

   ]
 
+  if (is_component_build) {
+    defines = [ "BUILDING_V8_SHARED" ]
+  }
+
   public_deps = [
     ":v8_libbase",
     ":v8_libplatform",
   ]
 }
 
 v8_source_set("simple_fuzzer") {
   sources = [
     "test/fuzzer/fuzzer.cc",
   ]
@@ skipping 228 matching lines @@
     ":internal_config_base",
   ]
 
   deps = [
     ":v8_libbase",
     ":v8_libplatform",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
 
+  defines = []
+
   if (is_component_build) {
     # v8_parser_shell can't be built against a shared library, so we
     # need to depend on the underlying static target in that case.
     deps += [ ":v8_maybe_snapshot" ]
+    defines += [ "BUILDING_V8_SHARED" ]

[Michael Achenbach, 2016/10/13 11:39:30]

Is this reflected in gyp?

[jochen (gone - plz use gerrit), 2016/10/13 12:16:34]

parser shell just doesn't work in gyp/shared_library

   } else {
     deps += [ ":v8" ]
   }
 
   if (v8_enable_i18n_support) {
     deps += [ "//third_party/icu" ]
   }
 
   if (is_win) {
     # Suppress warnings about importing locally defined symbols.
@@ skipping 67 matching lines @@
 
 v8_source_set("parser_fuzzer") {
   sources = [
     "test/fuzzer/parser.cc",
   ]
 
   deps = [
     ":fuzzer_support_nocomponent",
   ]
 
+  if (is_component_build) {
+    defines = [ "BUILDING_V8_SHARED" ]
+  }
+
   configs = [
     ":external_config",
     ":internal_config_base",
   ]
 }
 
 v8_fuzzer("parser_fuzzer") {
 }
 
 v8_source_set("regexp_fuzzer") {
@@ skipping 239 matching lines @@
   ]
 
   configs = [
     ":external_config",
     ":internal_config_base",
   ]
 }
 
 v8_fuzzer("wasm_data_section_fuzzer") {
 }