[MD History] Disable clicks in the date header of cards.

[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a9c75fd281a6d46fb86d66518bcdf2f82bd932dc
Cr-Commit-Position: refs/heads/master@{#427288}

[calamity, 2016-10-13 16:33:33]

Description was changed from

==========
[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
==========

to

==========
[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-10-13 16:37:43]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-10-13 16:37:43]

A side-effect of this is that the date is so longer selectable... I'm not sure
if there's a better way to do this. The core issue is that the history-item gets
focused when you click the header, which triggers selection.

WDYT?

[Dan Beam, 2016-10-13 17:40:24]

https://codereview.chromium.org/2420583003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/2420583003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_item.html:211:
on-mousedown="onTitleMousedown_">
can we just do pointer-events: none instead?  basically the same

[calamity, 2016-10-14 12:26:25]

https://codereview.chromium.org/2420583003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/2420583003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_item.html:211:
on-mousedown="onTitleMousedown_">
On 2016/10/13 17:40:24, Dan Beam wrote:
> can we just do pointer-events: none instead?  basically the same

Done.

[tsergeant, 2016-10-20 15:40:01]

lgtm with a question

https://codereview.chromium.org/2420583003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/2420583003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.html:22: pointer-events: none;
Is it possible to apply pointer-events: none to #date-accessed, removing the
need for the extra pointer-events: auto below?

[calamity, 2016-10-21 02:48:29]

On 2016/10/20 15:40:01, tsergeant wrote:
> lgtm with a question
> 
>
https://codereview.chromium.org/2420583003/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/md_history/history_item.html (right):
> 
>
https://codereview.chromium.org/2420583003/diff/20001/chrome/browser/resource...
> chrome/browser/resources/md_history/history_item.html:22: pointer-events:
none;
> Is it possible to apply pointer-events: none to #date-accessed, removing the
> need for the extra pointer-events: auto below?

Nope =( The pointer events then filter through to the card, focusing it.

[calamity, 2016-10-21 02:57:08]

Patchset #3 (id:40001) has been deleted

[calamity, 2016-10-21 02:57:12]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-10-21 02:57:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 02:57:44]

This CL has an open dependency (Issue 2420583003 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[calamity, 2016-10-24 04:16:16]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-10-24 04:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 04:16:25]

This CL has an open dependency (Issue 2420583003 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[calamity, 2016-10-25 04:15:59]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-10-25 04:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 04:16:17]

This CL has an open dependency (Issue 2420583003 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[calamity, 2016-10-25 04:16:25]

The CQ bit was unchecked by calamity@chromium.org

[calamity, 2016-10-25 04:17:20]

Description was changed from

==========
[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-10-25 04:17:23]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-10-25 04:17:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 04:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 04:19:30]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2016-10-25 04:54:56]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-10-25 04:54:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2420583003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-25 04:55:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 06:37:04]

Description was changed from

==========
[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-25 06:37:05]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-25 06:39:22]

Description was changed from

==========
[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Disable clicks in the date header of cards.

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a9c75fd281a6d46fb86d66518bcdf2f82bd932dc
Cr-Commit-Position: refs/heads/master@{#427288}
==========

[commit-bot: I haz the power, 2016-10-25 06:39:23]

Patchset 3 (id:??) landed as
https://crrev.com/a9c75fd281a6d46fb86d66518bcdf2f82bd932dc
Cr-Commit-Position: refs/heads/master@{#427288}