Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: scripts/slave/chromium/archive_layout_test_results.py

Issue 2420543002: Use passed-in --build-dir instead of GetBuildOutputDirectory in archive_layout_test_results.py. (Closed)
Patch Set: build_dir -> options.build_dir, revert changes in steps.py Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/chromium/archive_layout_test_results.py
diff --git a/scripts/slave/chromium/archive_layout_test_results.py b/scripts/slave/chromium/archive_layout_test_results.py
index 339231eb009698c77354b4e9fed388fb49d45157..7db4f3ee25e54605e27c3a58504fa98affdfe985 100755
--- a/scripts/slave/chromium/archive_layout_test_results.py
+++ b/scripts/slave/chromium/archive_layout_test_results.py
@@ -31,7 +31,6 @@ import sys
from common import archive_utils
from common import chromium_utils
-from slave import build_directory
from slave import slave_utils
# Directory name, above the build directory, in which test results can be
@@ -261,7 +260,8 @@ def archive_layout(options):
def _ParseOptions():
option_parser = optparse.OptionParser()
- option_parser.add_option('', '--build-dir', help='ignored')
+ option_parser.add_option('', '--build-dir',
+ help='Build dir path, relative to checkout root.')
option_parser.add_option('', '--results-dir',
help='path to layout test results, relative to '
'the build_dir')
@@ -286,7 +286,6 @@ def _ParseOptions():
'slave\'s build directory.')
chromium_utils.AddPropertiesOptions(option_parser)
options, _ = option_parser.parse_args()
- options.build_dir = build_directory.GetBuildOutputDirectory()
return options
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698