Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2420513002: DevTools: [SSP] fix hoverable selectors (Closed)

Created:
4 years, 2 months ago by lushnikov
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SSP] fix hoverable selectors We should initialize initial state of section so that it propogates to BlankPropertiesSection. BUG=655086 R=dgozman Committed: https://crrev.com/1c541e81dfe2ed204f982aefbda2f5a1d02fc077 Cr-Commit-Position: refs/heads/master@{#425146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look
4 years, 2 months ago (2016-10-12 22:25:40 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-13 00:42:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420513002/1
4 years, 2 months ago (2016-10-13 20:44:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 20:51:13 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 20:53:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c541e81dfe2ed204f982aefbda2f5a1d02fc077
Cr-Commit-Position: refs/heads/master@{#425146}

Powered by Google App Engine
This is Rietveld 408576698