[Offline Pages] Define separate watchdog timeout for concurrent bg loads

chrome/browser/android/offline_pages/background_scheduler_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/callback_android.h"
 #include "base/android/scoped_java_ref.h"
 #include "chrome/browser/android/offline_pages/background_scheduler_bridge.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 34 matching lines @@
   Profile* profile = ProfileManager::GetLastUsedProfile();
   RequestCoordinator* coordinator =
       RequestCoordinatorFactory::GetInstance()->
       GetForBrowserContext(profile);
   DVLOG(2) << "resource_coordinator: " << coordinator;
   DeviceConditions device_conditions(
       j_power_connected, j_battery_percentage,
       static_cast<net::NetworkChangeNotifier::ConnectionType>(
           j_net_connection_type));
   return coordinator->StartProcessing(
-      device_conditions, base::Bind(&ProcessingDoneCallback, j_callback_ref));
+      true /* is_background_scheduled */, device_conditions,

[Pete Williamson, 2016/10/12 22:33:24]

Let's not use a binary argument, they are hard to understand at the point of the
function call.  Perhaps an enum, or make const values indicating the meaning and
assign the values to true or false, using the value instead of true here.

[dougarnett, 2016/10/13 19:46:44]

ok, trying enum internally instead and reverting public api

+      base::Bind(&ProcessingDoneCallback, j_callback_ref));
 }
 
 void BackgroundSchedulerBridge::Schedule(
     const TriggerConditions& trigger_conditions) {
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_conditions =
       CreateTriggerConditions(env, trigger_conditions.require_power_connected,
                               trigger_conditions.minimum_battery_percentage,
                               trigger_conditions.require_unmetered_network);
   Java_BackgroundSchedulerBridge_schedule(env, j_conditions);
@@ skipping 24 matching lines @@
       env, require_power_connected, minimum_battery_percentage,
       require_unmetered_network);
 }
 
 bool RegisterBackgroundSchedulerBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace offline_pages