Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 242047: Try to fix AutocompleteEditViewTest failures on buildbot (issue 23213).... (Closed)

Created:
11 years, 2 months ago by James Su
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Try to fix AutocompleteEditViewTest failures on buildbot (issue 23213). The failures must be caused by timing issue. This CL tries to fix the issue by initializing all necessary components before running tests. BUG=23213 AutocompleteEditViewTest tests are failing TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc View 8 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Su
11 years, 2 months ago (2009-09-29 06:36:29 UTC) #1
Peter Kasting
This is fine with me, but I don't understand why this would fix the AltEnter ...
11 years, 2 months ago (2009-09-29 16:57:21 UTC) #2
James Su
Does this CL fix the issue on the quad core bot? On 2009/09/29 16:57:21, Peter ...
11 years, 2 months ago (2009-09-29 17:36:12 UTC) #3
Nicolas Sylvain
I don't understand either, but the code LGTM. you can try it, just make sure ...
11 years, 2 months ago (2009-09-29 17:47:51 UTC) #4
James Su
11 years, 2 months ago (2009-09-30 05:57:57 UTC) #5
I just submitted this CL, seems it works.

Thanks
James Su

On 2009/09/29 17:47:51, Nicolas Sylvain wrote:
> I don't understand either, but the code LGTM. you can try it, just make sure
you
> stick around after you commit to see if it helped or not, and can re-disable
the
> tests if it does not.

Powered by Google App Engine
This is Rietveld 408576698