Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2420463002: Fix a deprecated declaration warning in browsercrapplication+applescript_test.mm. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a deprecated declaration warning in browsercrapplication+applescript_test.mm. The test was trying to call a method on an untyped object. BUG=655279 Committed: https://crrev.com/1ac97ed3b0abc4370979ebbebeafa622ff2c7749 Cr-Commit-Position: refs/heads/master@{#424857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
erikchen
rsesek: Please review.
4 years, 2 months ago (2016-10-12 20:47:36 UTC) #3
Robert Sesek
lgtm
4 years, 2 months ago (2016-10-12 20:48:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420463002/1
4 years, 2 months ago (2016-10-12 20:52:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 21:22:00 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:26:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ac97ed3b0abc4370979ebbebeafa622ff2c7749
Cr-Commit-Position: refs/heads/master@{#424857}

Powered by Google App Engine
This is Rietveld 408576698