Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2420423002: [DevTools] pass v8_inspector_js_protocol as default for .imported.path in conf (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] pass v8_inspector_js_protocol as default for .imported.path in conf BUG=chromium:635948 R=dgozman@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/inspector_protocol_config.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 3 chunks +4 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gni View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
kozy
Dmitry, please take a look.
4 years, 2 months ago (2016-10-16 23:47:05 UTC) #3
dgozman
https://codereview.chromium.org/2420423002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py (right): https://codereview.chromium.org/2420423002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py#newcode55 third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:55: cmdline_parser.add_option("--imported_protocol_path") I don't really like this parameter being that ...
4 years, 2 months ago (2016-10-17 19:16:39 UTC) #6
kozy
4 years, 2 months ago (2016-10-17 19:35:05 UTC) #8
Message was sent while issue was closed. 
Let's postpone before we really need it.

Powered by Google App Engine
This is Rietveld 408576698