Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2420373002:
[wasm] Test deserialized module still has bytes, + negative test (Closed)
|
Created:
4 years, 2 months ago by Mircea Trofin Modified:
4 years, 2 months ago Reviewers:
bradnelson CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] Test deserialized module still has bytes, + negative test
BUG=
Committed: https://crrev.com/5bbf88bc4424b0f45989a8d47dd83479d72b10f9
Cr-Commit-Position: refs/heads/master@{#40376}
Patch Set 1 #
Total comments: 2
Patch Set 2 : [wasm] Test deserialized module still has bytes, + negative test #
Messages
Total messages: 25 (19 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [wasm] Test deserialized module still has bytes, + negative test BUG= ========== to ========== [wasm] Test deserialized module still has bytes, + negative test BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org
Forgot some testing, and, surely enough, had a bug hidden by that. Fixed.
lgtm https://codereview.chromium.org/2420373002/diff/1/test/cctest/wasm/test-run-w... File test/cctest/wasm/test-run-wasm-module.cc (right): https://codereview.chromium.org/2420373002/diff/1/test/cctest/wasm/test-run-w... test/cctest/wasm/test-run-wasm-module.cc:233: for (int i = 0; i < 4; ++i) { The numeric counting is getting hard to follow here. Turn into a TEST_F ?
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2420373002/#ps40001 (title: "[wasm] Test deserialized module still has bytes, + negative test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2420373002/diff/1/test/cctest/wasm/test-run-w... File test/cctest/wasm/test-run-wasm-module.cc (right): https://codereview.chromium.org/2420373002/diff/1/test/cctest/wasm/test-run-w... test/cctest/wasm/test-run-wasm-module.cc:233: for (int i = 0; i < 4; ++i) { On 2016/10/17 20:38:04, bradnelson wrote: > The numeric counting is getting hard to follow here. > Turn into a TEST_F ? Currently, TEST_F isn't available to cctest. I refactored along the lines of a TEST_F, to move forward, and will investigate the motivation for not using the gtest framework in cctests. At minimum, the tests are more readable now.
Message was sent while issue was closed.
Description was changed from ========== [wasm] Test deserialized module still has bytes, + negative test BUG= ========== to ========== [wasm] Test deserialized module still has bytes, + negative test BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Test deserialized module still has bytes, + negative test BUG= ========== to ========== [wasm] Test deserialized module still has bytes, + negative test BUG= Committed: https://crrev.com/5bbf88bc4424b0f45989a8d47dd83479d72b10f9 Cr-Commit-Position: refs/heads/master@{#40376} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5bbf88bc4424b0f45989a8d47dd83479d72b10f9 Cr-Commit-Position: refs/heads/master@{#40376} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
