Issue 2420323002: Don't use in-class initialization of non-static data members. It's a C++11 extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2420323002: Don't use in-class initialization of non-static data members. It's a C++11 extension. (Closed)

Created:
4 years, 2 months ago by Vyacheslav Egorov (Google)

Modified:
4 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use in-class initialization of non-static data members. It's a C++11 extension. TBR=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/caa0167457f83b3bdda99b1385b1816a3ea3947d

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	runtime/vm/kernel_to_il.h	View		1 chunk	+16 lines, -7 lines	0 comments	Download

Total messages: 4 (3 generated)

Vyacheslav Egorov (Google)

4 years, 2 months ago (2016-10-15 21:02:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
caa0167457f83b3bdda99b1385b1816a3ea3947d (presubmit successful).