Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2420303002: Remove usage of FOR_EACH_OBSERVER macro in platform/scheduler (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
index a417cae0f9f0e4f0d5da59a5a557283319d86ca5..1cd92beb468e32204b61ba680029b2ef6e84254d 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
@@ -261,10 +261,11 @@ void TaskQueueManager::DoWork(base::TimeTicks run_time, bool from_main_thread) {
if (!delegate_->IsNested() && task_start_time != base::TimeTicks()) {
// Only report top level task durations.
base::TimeTicks task_end_time = lazy_now.Now();
- FOR_EACH_OBSERVER(
- TaskTimeObserver, task_time_observers_,
- ReportTaskTime(task_queue, MonotonicTimeInSeconds(task_start_time),
- MonotonicTimeInSeconds(task_end_time)));
+ for (auto& observer : task_time_observers_) {
+ observer.ReportTaskTime(task_queue,
+ MonotonicTimeInSeconds(task_start_time),
+ MonotonicTimeInSeconds(task_end_time));
+ }
task_start_time = task_end_time;
}
@@ -342,8 +343,8 @@ TaskQueueManager::ProcessTaskResult TaskQueueManager::ProcessTaskFromWorkQueue(
TRACE_TASK_EXECUTION("TaskQueueManager::ProcessTaskFromWorkQueue",
pending_task);
if (queue->GetShouldNotifyObservers()) {
- FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_,
- WillProcessTask(pending_task));
+ for (auto& observer : task_observers_)
+ observer.WillProcessTask(pending_task);
queue->NotifyWillProcessTask(pending_task);
}
TRACE_EVENT1(tracing_category_, "TaskQueueManager::RunTask", "queue",
@@ -363,8 +364,8 @@ TaskQueueManager::ProcessTaskResult TaskQueueManager::ProcessTaskFromWorkQueue(
currently_executing_task_queue_ = prev_executing_task_queue;
if (queue->GetShouldNotifyObservers()) {
- FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_,
- DidProcessTask(pending_task));
+ for (auto& observer : task_observers_)
+ observer.DidProcessTask(pending_task);
queue->NotifyDidProcessTask(pending_task);
}
« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698