Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: runtime/lib/function.cc

Issue 24203004: Dart VM: Simplify code generation for equality operators. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/bootstrap_natives.h" 5 #include "vm/bootstrap_natives.h"
6 6
7 #include "vm/compiler.h" 7 #include "vm/compiler.h"
8 #include "vm/dart_entry.h" 8 #include "vm/dart_entry.h"
9 #include "vm/exceptions.h" 9 #include "vm/exceptions.h"
10 #include "vm/native_entry.h" 10 #include "vm/native_entry.h"
(...skipping 15 matching lines...) Expand all
26 } 26 }
27 return result.raw(); 27 return result.raw();
28 } 28 }
29 29
30 30
31 DEFINE_NATIVE_ENTRY(FunctionImpl_equals, 2) { 31 DEFINE_NATIVE_ENTRY(FunctionImpl_equals, 2) {
32 const Instance& receiver = Instance::CheckedHandle( 32 const Instance& receiver = Instance::CheckedHandle(
33 isolate, arguments->NativeArgAt(0)); 33 isolate, arguments->NativeArgAt(0));
34 ASSERT(receiver.IsClosure()); 34 ASSERT(receiver.IsClosure());
35 GET_NATIVE_ARGUMENT(Instance, other, arguments->NativeArgAt(1)); 35 GET_NATIVE_ARGUMENT(Instance, other, arguments->NativeArgAt(1));
36 ASSERT(!other.IsNull());
36 if (receiver.raw() == other.raw()) return Bool::True().raw(); 37 if (receiver.raw() == other.raw()) return Bool::True().raw();
37 if (other.IsClosure()) { 38 if (other.IsClosure()) {
38 const Function& func_a = Function::Handle(Closure::function(receiver)); 39 const Function& func_a = Function::Handle(Closure::function(receiver));
39 const Function& func_b = Function::Handle(Closure::function(other)); 40 const Function& func_b = Function::Handle(Closure::function(other));
40 if (func_a.raw() == func_b.raw()) { 41 if (func_a.raw() == func_b.raw()) {
41 ASSERT(!func_a.IsImplicitStaticClosureFunction()); 42 ASSERT(!func_a.IsImplicitStaticClosureFunction());
42 if (func_a.IsImplicitInstanceClosureFunction()) { 43 if (func_a.IsImplicitInstanceClosureFunction()) {
43 const Context& context_a = Context::Handle(Closure::context(receiver)); 44 const Context& context_a = Context::Handle(Closure::context(receiver));
44 const Context& context_b = Context::Handle(Closure::context(other)); 45 const Context& context_b = Context::Handle(Closure::context(other));
45 const Instance& receiver_a = Instance::Handle(context_a.At(0)); 46 const Instance& receiver_a = Instance::Handle(context_a.At(0));
(...skipping 21 matching lines...) Expand all
67 result ^= result >> 11; 68 result ^= result >> 11;
68 result += result << 15; 69 result += result << 15;
69 result &= ((static_cast<intptr_t>(1) << String::kHashBits) - 1); 70 result &= ((static_cast<intptr_t>(1) << String::kHashBits) - 1);
70 return Smi::New(result); 71 return Smi::New(result);
71 } 72 }
72 UNREACHABLE(); 73 UNREACHABLE();
73 return Object::null(); 74 return Object::null();
74 } 75 }
75 76
76 } // namespace dart 77 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698