Source/bindings/v8/ExceptionMessages.cpp - Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ExceptionMessages.cpp

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: FAIL. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ExceptionMessages.cpp

diff --git a/Source/bindings/v8/ExceptionMessages.cpp b/Source/bindings/v8/ExceptionMessages.cpp

index 0309f1dd5b723e7b4d9f15c515bf08b5e9ad0e23..0813eb736f11067e1b2d6d1b3ba2a34185d8898e 100644

--- a/Source/bindings/v8/ExceptionMessages.cpp

+++ b/Source/bindings/v8/ExceptionMessages.cpp

@@ -33,6 +33,11 @@

namespace WebCore {

+String ExceptionMessages::failedToConstruct(const String& type, const String& detail)

+ return "Failed to construct '" + type + (!detail.isEmpty() ? String("': " + detail) : String("'"));

String ExceptionMessages::failedToExecute(const String& method, const String& type, const String& detail)

{

return "Failed to execute '" + method + "' on '" + type + (!detail.isEmpty() ? String("': " + detail) : String("'"));