Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: FAIL. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp b/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
index 85c02402335ed98ebbf088bb5514151882dde6f0..6aed2746eee33cd6e78fc313e2561920c1f5a5f1 100644
--- a/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
@@ -22,6 +22,7 @@
#include "V8TestInterfaceImplementedAs.h"
#include "RuntimeEnabledFeatures.h"
+#include "bindings/v8/ExceptionMessages.h"
#include "bindings/v8/ExceptionState.h"
#include "bindings/v8/ScriptController.h"
#include "bindings/v8/V8Binding.h"
@@ -123,7 +124,7 @@ static void bAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::V
static void func1Method(const v8::FunctionCallbackInfo<v8::Value>& args)
{
if (UNLIKELY(args.Length() < 1)) {
- throwNotEnoughArgumentsError(args.GetIsolate());
+ throwTypeError(ExceptionMessages::failedToExecute("func1", "RealClass", "1 argument required, but only " + String::number(args.Length()) + " present."), args.GetIsolate());
return;
}
RealClass* imp = V8TestInterfaceImplementedAs::toNative(args.Holder());
@@ -142,7 +143,7 @@ static void func1MethodCallback(const v8::FunctionCallbackInfo<v8::Value>& args)
static void funcTestInterfaceImplementedAsParamMethod(const v8::FunctionCallbackInfo<v8::Value>& args)
{
if (UNLIKELY(args.Length() < 1)) {
- throwNotEnoughArgumentsError(args.GetIsolate());
+ throwTypeError(ExceptionMessages::failedToExecute("funcTestInterfaceImplementedAsParam", "RealClass", "1 argument required, but only " + String::number(args.Length()) + " present."), args.GetIsolate());
return;
}
RealClass* imp = V8TestInterfaceImplementedAs::toNative(args.Holder());

Powered by Google App Engine
This is Rietveld 408576698