Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: Source/bindings/tests/results/V8TestCustomAccessors.cpp

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: FAIL. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestCustomAccessors.cpp
diff --git a/Source/bindings/tests/results/V8TestCustomAccessors.cpp b/Source/bindings/tests/results/V8TestCustomAccessors.cpp
index 54ad64f46995703b82da214f363f6f2f1618b03a..d3a06b7bbdb3f8ec0c6c229acb6b119c08f1876b 100644
--- a/Source/bindings/tests/results/V8TestCustomAccessors.cpp
+++ b/Source/bindings/tests/results/V8TestCustomAccessors.cpp
@@ -22,6 +22,7 @@
#include "V8TestCustomAccessors.h"
#include "RuntimeEnabledFeatures.h"
+#include "bindings/v8/ExceptionMessages.h"
#include "bindings/v8/ExceptionState.h"
#include "bindings/v8/ScriptController.h"
#include "bindings/v8/V8Binding.h"
@@ -63,7 +64,7 @@ template <typename T> void V8_USE(T) { }
static void anotherFunctionMethod(const v8::FunctionCallbackInfo<v8::Value>& args)
{
if (UNLIKELY(args.Length() < 1)) {
- throwNotEnoughArgumentsError(args.GetIsolate());
+ throwTypeError(ExceptionMessages::failedToExecute("anotherFunction", "TestCustomAccessors", "1 argument required, but only " + String::number(args.Length()) + " present."), args.GetIsolate());
return;
}
TestCustomAccessors* imp = V8TestCustomAccessors::toNative(args.Holder());

Powered by Google App Engine
This is Rietveld 408576698