LayoutTests/fast/dom/characterdata-api-arguments.html - Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions.

Unified Diff: LayoutTests/fast/dom/characterdata-api-arguments.html

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaseline Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt ('k') | LayoutTests/fast/dom/characterdata-api-arguments-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/characterdata-api-arguments.html

diff --git a/LayoutTests/fast/dom/characterdata-api-arguments.html b/LayoutTests/fast/dom/characterdata-api-arguments.html

index 221512af34de82f6f5cf94d6386f416d672390d1..554e5679d945c621b6ff5843ce6e198926097b6d 100644

--- a/LayoutTests/fast/dom/characterdata-api-arguments.html

+++ b/LayoutTests/fast/dom/characterdata-api-arguments.html

@@ -15,16 +15,16 @@ shouldBe("text.__proto__.__proto__", "CharacterData.prototype");

// appendData()

shouldNotThrow("text.appendData('efg')");

shouldBeEqualToString("text.data", "abcdefg");

-shouldThrow("text.appendData()", "'TypeError: Not enough arguments'");

+shouldThrow("text.appendData()", '"TypeError: Failed to execute \'appendData\' on \'CharacterData\': 1 argument required, but only 0 present."');

shouldBeEqualToString("text.data", "abcdefg");

// insertData()

text.data = "efg";

shouldNotThrow("text.insertData(0, 'abcd')");

shouldBeEqualToString("text.data", "abcdefg");

-shouldThrow("text.insertData()", "'TypeError: Not enough arguments'");

+shouldThrow("text.insertData()", '"TypeError: Failed to execute \'insertData\' on \'CharacterData\': 2 arguments required, but only 0 present."');

shouldBeEqualToString("text.data", "abcdefg");

-shouldThrow("text.insertData(0)", "'TypeError: Not enough arguments'");

+shouldThrow("text.insertData(0)", '"TypeError: Failed to execute \'insertData\' on \'CharacterData\': 2 arguments required, but only 1 present."');

shouldBeEqualToString("text.data", "abcdefg");

shouldThrow("text.insertData(999, 'test')", '"IndexSizeError: Failed to execute \'insertData\' on \'CharacterData\': The offset 999 is greater than the node\'s length (7)."');

shouldBeEqualToString("text.data", "abcdefg");

@@ -35,9 +35,9 @@ shouldBeEqualToString("text.data", "abtestcdefg");

text.data = "abcdefg";

shouldNotThrow("text.deleteData(4, 3)");

shouldBeEqualToString("text.data", "abcd");

-shouldThrow("text.deleteData()", "'TypeError: Not enough arguments'");

+shouldThrow("text.deleteData()", '"TypeError: Failed to execute \'deleteData\' on \'CharacterData\': 2 arguments required, but only 0 present."');

shouldBeEqualToString("text.data", "abcd");

-shouldThrow("text.deleteData(0)", "'TypeError: Not enough arguments'");

+shouldThrow("text.deleteData(0)", '"TypeError: Failed to execute \'deleteData\' on \'CharacterData\': 2 arguments required, but only 1 present."');

shouldBeEqualToString("text.data", "abcd");

shouldThrow("text.deleteData(999, 3)", '"IndexSizeError: Failed to execute \'deleteData\' on \'CharacterData\': The offset 999 is greater than the node\'s length (4)."');

shouldBeEqualToString("text.data", "abcd");

@@ -52,11 +52,11 @@ shouldBeEqualToString("text.data", "a");

text.data = "efg";

shouldNotThrow("text.replaceData(0, 0, 'abcd')");

shouldBeEqualToString("text.data", "abcdefg");

-shouldThrow("text.replaceData()", "'TypeError: Not enough arguments'");

+shouldThrow("text.replaceData()", '"TypeError: Failed to execute \'replaceData\' on \'CharacterData\': 3 arguments required, but only 0 present."');

shouldBeEqualToString("text.data", "abcdefg");

-shouldThrow("text.replaceData(0)", "'TypeError: Not enough arguments'");

+shouldThrow("text.replaceData(0)", '"TypeError: Failed to execute \'replaceData\' on \'CharacterData\': 3 arguments required, but only 1 present."');

shouldBeEqualToString("text.data", "abcdefg");

-shouldThrow("text.replaceData(0, 0)", "'TypeError: Not enough arguments'");

+shouldThrow("text.replaceData(0, 0)", '"TypeError: Failed to execute \'replaceData\' on \'CharacterData\': 3 arguments required, but only 2 present."');

shouldBeEqualToString("text.data", "abcdefg");

shouldThrow("text.replaceData(999, 3, 'test')", '"IndexSizeError: Failed to execute \'replaceData\' on \'CharacterData\': The offset 999 is greater than the node\'s length (7)."');

shouldBeEqualToString("text.data", "abcdefg");

@@ -70,8 +70,8 @@ shouldBeEqualToString("text.data", "aaaa");

// substringData()

text.data = "abcdefg";

shouldBeEqualToString("text.substringData(4, 3)", "efg");

-shouldThrow("text.substringData()", "'TypeError: Not enough arguments'");

-shouldThrow("text.substringData(0)", "'TypeError: Not enough arguments'");

+shouldThrow("text.substringData()", '"TypeError: Failed to execute \'substringData\' on \'CharacterData\': 2 arguments required, but only 0 present."');

+shouldThrow("text.substringData(0)", '"TypeError: Failed to execute \'substringData\' on \'CharacterData\': 2 arguments required, but only 1 present."');

shouldBeEqualToString("text.substringData(4, 999)", "efg"); // Length argument is too large, should be adjusted.

shouldBeEqualToString("text.substringData(4, -1)", "efg"); // Length argument is too large (after wrapping), should be adjusted.

shouldThrow("text.substringData(-1, 2)", '"IndexSizeError: Failed to execute \'substringData\' on \'CharacterData\': The offset 4294967295 is greater than the node\'s length (7)."'); // Wraps to 4294967295 which is greater than the data length