Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/renderer/chrome_render_frame_observer_browsertest.cc

Issue 2420253002: Rename shell namespace to service_manager (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/chrome_render_frame_observer.h" 5 #include "chrome/renderer/chrome_render_frame_observer.h"
6 6
7 #include <tuple> 7 #include <tuple>
8 8
9 #include "base/test/histogram_tester.h" 9 #include "base/test/histogram_tester.h"
10 #include "chrome/test/base/chrome_render_view_test.h" 10 #include "chrome/test/base/chrome_render_view_test.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 } // namespace 50 } // namespace
51 51
52 // Constants for UMA statistic collection. 52 // Constants for UMA statistic collection.
53 static const char kTranslateCaptureText[] = "Translate.CaptureText"; 53 static const char kTranslateCaptureText[] = "Translate.CaptureText";
54 54
55 class ChromeRenderFrameObserverTest : public ChromeRenderViewTest { 55 class ChromeRenderFrameObserverTest : public ChromeRenderViewTest {
56 protected: 56 protected:
57 void SetUp() override { 57 void SetUp() override {
58 ChromeRenderViewTest::SetUp(); 58 ChromeRenderViewTest::SetUp();
59 59
60 shell::InterfaceProvider* remote_interfaces = 60 service_manager::InterfaceProvider* remote_interfaces =
61 view_->GetMainRenderFrame()->GetRemoteInterfaces(); 61 view_->GetMainRenderFrame()->GetRemoteInterfaces();
62 shell::InterfaceProvider::TestApi test_api(remote_interfaces); 62 service_manager::InterfaceProvider::TestApi test_api(remote_interfaces);
63 test_api.SetBinderForName( 63 test_api.SetBinderForName(
64 translate::mojom::ContentTranslateDriver::Name_, 64 translate::mojom::ContentTranslateDriver::Name_,
65 base::Bind(&FakeContentTranslateDriver::BindHandle, 65 base::Bind(&FakeContentTranslateDriver::BindHandle,
66 base::Unretained(&fake_translate_driver_))); 66 base::Unretained(&fake_translate_driver_)));
67 } 67 }
68 68
69 FakeContentTranslateDriver fake_translate_driver_; 69 FakeContentTranslateDriver fake_translate_driver_;
70 }; 70 };
71 71
72 TEST_F(ChromeRenderFrameObserverTest, SkipCapturingSubFrames) { 72 TEST_F(ChromeRenderFrameObserverTest, SkipCapturingSubFrames) {
73 base::HistogramTester histogram_tester; 73 base::HistogramTester histogram_tester;
74 LoadHTML( 74 LoadHTML(
75 "<!DOCTYPE html><body>" 75 "<!DOCTYPE html><body>"
76 "This is a main document" 76 "This is a main document"
77 "<iframe srcdoc=\"This a document in an iframe.\">" 77 "<iframe srcdoc=\"This a document in an iframe.\">"
78 "</body>"); 78 "</body>");
79 view_->GetWebView()->updateAllLifecyclePhases(); 79 view_->GetWebView()->updateAllLifecyclePhases();
80 80
81 base::RunLoop().RunUntilIdle(); 81 base::RunLoop().RunUntilIdle();
82 ASSERT_TRUE(fake_translate_driver_.called_new_page_); 82 ASSERT_TRUE(fake_translate_driver_.called_new_page_);
83 EXPECT_TRUE(fake_translate_driver_.page_needs_translation_) 83 EXPECT_TRUE(fake_translate_driver_.page_needs_translation_)
84 << "Page should be translatable."; 84 << "Page should be translatable.";
85 // Should have 2 samples: one for preliminary capture, one for final capture. 85 // Should have 2 samples: one for preliminary capture, one for final capture.
86 // If there are more, then subframes are being captured more than once. 86 // If there are more, then subframes are being captured more than once.
87 histogram_tester.ExpectTotalCount(kTranslateCaptureText, 2); 87 histogram_tester.ExpectTotalCount(kTranslateCaptureText, 2);
88 } 88 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698