third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp - Issue 2420223002: Dispatching errors across iframes don't match webplatform tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

Issue 2420223002: Dispatching errors across iframes don't match webplatform tests

Patch Set: Added nested errors test and scope class." Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

index 9acda710530f48c82a190e91d02430a41fcd750f..9d29aea1ae60ea5a042451d4f93b563b2dfde5d5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

@@ -106,6 +106,8 @@ v8::Local<v8::Value> V8EventListener::callListenerFunction(

!frame->script().canExecuteScripts(AboutToExecuteScript))

return v8::Local<v8::Value>();

+ ScriptStateForErrorEvent::Scope scope(scriptState,

+ handlerFunction->CreationContext());

v8::Local<v8::Value> parameters[1] = {jsEvent};

v8::Local<v8::Value> result;

if (!V8ScriptRunner::callFunction(handlerFunction, frame->document(),