third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp - Issue 2420223002: Dispatching errors across iframes don't match webplatform tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2420223002: Dispatching errors across iframes don't match webplatform tests

Patch Set: Refactored ScriptStateForErrorEvent, added error handler to the test." Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptState.h ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptState.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "bindings/core/v8/ScriptState.h"	5 #include "bindings/core/v8/ScriptState.h"

6	6

7 #include "bindings/core/v8/V8Binding.h"	7 #include "bindings/core/v8/V8Binding.h"

8 #include "core/dom/ExecutionContext.h"	8 #include "core/dom/ExecutionContext.h"

9 #include "core/frame/LocalDOMWindow.h"	9 #include "core/frame/LocalDOMWindow.h"

10 #include "core/frame/LocalFrame.h"	10 #include "core/frame/LocalFrame.h"

(...skipping 85 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
96 ASSERT(frame);	96 ASSERT(frame);

97 v8::HandleScope handleScope(toIsolate(frame));	97 v8::HandleScope handleScope(toIsolate(frame));

98 v8::Local<v8::Context> context = toV8Context(frame, world);	98 v8::Local<v8::Context> context = toV8Context(frame, world);

99 if (context.IsEmpty())	99 if (context.IsEmpty())

100 return nullptr;	100 return nullptr;

101 ScriptState* scriptState = ScriptState::from(context);	101 ScriptState* scriptState = ScriptState::from(context);

102 ASSERT(scriptState->contextIsValid());	102 ASSERT(scriptState->contextIsValid());

103 return scriptState;	103 return scriptState;

104 }	104 }

105	105

	106 ScriptStateForErrorEvent* ScriptStateForErrorEvent::s_topOfStack = nullptr;

	107

106 } // namespace blink	108 } // namespace blink

OLD	NEW