Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: components/sync/engine_impl/worker_entity_tracker.cc

Issue 2420213002: [USS] Show USS counters in Types tab (Closed)
Patch Set: git rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/worker_entity_tracker.cc
diff --git a/components/sync/engine_impl/worker_entity_tracker.cc b/components/sync/engine_impl/worker_entity_tracker.cc
index 2e0ca7bfb65e0c6e293915302b4d1becbc147779..1ad0285125db90686cd7c11b4b75d313272bcc24 100644
--- a/components/sync/engine_impl/worker_entity_tracker.cc
+++ b/components/sync/engine_impl/worker_entity_tracker.cc
@@ -127,7 +127,7 @@ void WorkerEntityTracker::ReceiveCommitResponse(CommitResponseData* ack) {
}
void WorkerEntityTracker::ReceiveUpdate(const UpdateResponseData& update) {
- if (update.response_version <= highest_gu_response_version_)
+ if (!UpdateContainsNewVersion(update))
return;
highest_gu_response_version_ = update.response_version;
@@ -144,6 +144,13 @@ void WorkerEntityTracker::ReceiveUpdate(const UpdateResponseData& update) {
}
}
+bool WorkerEntityTracker::UpdateContainsNewVersion(
+ const UpdateResponseData& update) {
+ if (update.response_version <= highest_gu_response_version_)
pavely 2016/10/19 18:18:59 It is easier to read if condition follows name/sem
Gang Wu 2016/10/20 21:35:36 Done.
+ return false;
+ return true;
+}
+
bool WorkerEntityTracker::ReceiveEncryptedUpdate(
const UpdateResponseData& data) {
if (data.response_version < highest_gu_response_version_)

Powered by Google App Engine
This is Rietveld 408576698